fix: Do not retry RPC requests on 4xx errors

[spalladino]

Any error on a transaction that used capsules was causing a no capsules available error, even if unrelated to the capsule. Reason for this is that our remote pxe client was configured by default to retry all failed requests (but not on e2e tests), so the first attempt would raise the actual error and consume the capsule, and all retries would fail since the first request consumed the capsule.

Barring actually fixing capsules (still pending), a fix is not retrying a request upon a 4xx error, so we don't unnecessarily hammer the pxe. Note that retries had been originally introduced to handle connectivity errors, I expect that those would not be raised as 4xx's.

[alexghr]

wow, great find!

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_successful_decrypting_time_in_ms (32): 624 (+17%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit aa0d2e4b and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,412	6,412	6,424
l1_rollup_execution_gas	585,745	585,745	585,757
l2_block_processing_time_in_ms	1,313 (+1%)	4,823 (+2%)	9,494
note_successful_decrypting_time_in_ms	228 (-8%)	⚠️ 624 (+17%)	999 (-5%)
note_trial_decrypting_time_in_ms	27.7 (-41%)	33.1 (-24%)	114 (+63%)
l2_block_building_time_in_ms	11,878	42,968	84,242
l2_block_rollup_simulation_time_in_ms	11,845	42,852	84,017
l2_block_public_tx_process_time_in_ms	6,187	24,115	48,128 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,284 (-2%)	27,247 (-1%)
note_history_successful_decrypting_time_in_ms	1,370 (+4%)	2,459 (+2%)
note_history_trial_decrypting_time_in_ms	61.0 (-3%)	108 (+6%)
node_database_size_in_bytes	18,616,400	34,996,304
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	179 (-1%)	44,377	26,164
private-kernel-ordering	160 (-1%)	50,830	39,026
base-parity	3,969 (+4%)	128	311
root-parity	1,093	1,244	311
base-rollup	14,259 (+1%)	110,464	861
root-rollup	49.9 (+1%)	4,359	725
private-kernel-inner	216	71,744	26,164
public-kernel-app-logic	119 (-2%)	47,695	40,661
public-kernel-tail	162 (-1%)	53,372	7,125
merge-rollup	9.65 (-9%)	2,568	861
public-kernel-teardown	118 (+1%)	47,695	40,661
public-kernel-setup	116 (+1%)	47,695	40,661

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1 (+1%)	16.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.590 (+1%)	0.496	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.8 (-1%)	72.2	231	445 (-1%)	876	1,739	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.469 (-1%)	0.445 (-1%)	0.421	0.416 (-1%)	0.415	0.416	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.1	107	338 (+1%)	656 (-1%)	1,314	2,612 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.478	0.480	0.458	0.450 (-1%)	0.455	0.454 (-1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	60.9
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.531 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	40,372	496,534

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,692	1,076	5,374

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	572 (-1%)	401 (+1%)	1,072 (+1%)	521 (+6%)	1,745	583