feat: verify public data reads

[LeilaWang]

Please read contributing guidelines and remove this line.

[AztecBot]

Benchmark results

Metrics with a significant change:

• circuit_simulation_time_in_ms (base-rollup): 18,925 (+18%)
• circuit_simulation_time_in_ms (public-kernel-tail): 366 (+195%)
• circuit_input_size_in_bytes (public-kernel-tail): 157,432 (+162%)
• tx_sequencer_processing_time_ms (1): 774 (+56%)
• tx_sequencer_processing_time_ms (2): 654 (+98%)
• tx_sequencer_processing_time_ms (3): 1,251 (+40%)
• tx_sequencer_processing_time_ms (4): 817 (+95%)
• tx_sequencer_processing_time_ms (5): 1,918 (+29%)
• tx_sequencer_processing_time_ms (8): 1,059 (+117%)
• l2_block_building_time_in_ms (8): 17,653 (+33%)
• l2_block_building_time_in_ms (32): 69,450 (+33%)
• l2_block_building_time_in_ms (64): 139,114 (+34%)
• l2_block_rollup_simulation_time_in_ms (8): 17,424 (+33%)
• l2_block_rollup_simulation_time_in_ms (32): 68,606 (+33%)
• l2_block_rollup_simulation_time_in_ms (64): 137,453 (+35%)
• l2_block_public_tx_process_time_in_ms (8): 7,990 (+41%)
• l2_block_public_tx_process_time_in_ms (32): 31,099 (+37%)
• l2_block_public_tx_process_time_in_ms (64): 62,873 (+40%)
• note_trial_decrypting_time_in_ms (32): 18.3 (-80%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,844	6,844 (+1%)	6,844
l1_rollup_execution_gas	587,325	587,325	587,325
l2_block_processing_time_in_ms	1,446 (-2%)	5,359 (-1%)	10,416 (-2%)
note_successful_decrypting_time_in_ms	229 (-4%)	606 (+4%)	974 (+8%)
note_trial_decrypting_time_in_ms	31.3 (-43%)	⚠️ 18.3 (-80%)	92.2 (-24%)
l2_block_building_time_in_ms	⚠️ 17,653 (+33%)	⚠️ 69,450 (+33%)	⚠️ 139,114 (+34%)
l2_block_rollup_simulation_time_in_ms	⚠️ 17,424 (+33%)	⚠️ 68,606 (+33%)	⚠️ 137,453 (+35%)
l2_block_public_tx_process_time_in_ms	⚠️ 7,990 (+41%)	⚠️ 31,099 (+37%)	⚠️ 62,873 (+40%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,499 (-3%)	29,900 (-1%)
note_history_successful_decrypting_time_in_ms	1,163 (-6%)	2,325 (+5%)
note_history_trial_decrypting_time_in_ms	34.4 (-33%)	86.9 (-29%)
node_database_size_in_bytes	18,731,088	35,037,264
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	152 (+2%)	44,725	26,424
private-kernel-inner	162 (+1%)	72,200	26,424
private-kernel-ordering	111 (+1%)	51,090	39,297
base-parity	40.9 (+2%)	128	311
root-parity	7.07 (-1%)	1,244	311
base-rollup	⚠️ 18,925 (+18%)	110,928	957
root-rollup	47.4	4,551	821
public-kernel-app-logic	90.2 (+1%)	48,175	40,933
public-kernel-tail	⚠️ 366 (+195%)	⚠️ 157,432 (+162%)	7,493 (+1%)
merge-rollup	6.90 (-8%)	2,760	957
public-kernel-teardown	85.6	48,175	40,933
public-kernel-setup	84.2 (-1%)	48,175	40,933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.0 (-1%)	17.7	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.638 (-1%)	0.549	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	52.1 (+1%)	80.5 (-1%)	261 (-2%)	498 (-1%)	989 (-1%)	1,969 (-1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.534 (+1%)	0.496 (-1%)	0.476 (-1%)	0.466 (-1%)	0.469 (-2%)	0.471 (-2%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.1	120 (-1%)	380 (-3%)	736	1,470 (-3%)	2,924 (-3%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.533	0.540 (-2%)	0.516 (-3%)	0.507	0.509 (-3%)	0.509 (-3%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	67.1 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.587 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	41,029	528,895

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,209 (+1%)	796 (+1%)	3,427

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	⚠️ 774 (+56%)	⚠️ 654 (+98%)	⚠️ 1,251 (+40%)	⚠️ 817 (+95%)	⚠️ 1,918 (+29%)	⚠️ 1,059 (+117%)

[LeilaWang]

This and validate_nullifier_non_existent_read_requests below are copied from public tail.

[LeilaWang]

Prove nullifier (non-)membership against the root at the start of a tx.

[LeilaWang]

Removed the check:

let is_empty_leaf = (low_key == 0) & (next_key == 0);
assert(!is_empty_leaf);

Reason is added to a comment below with the test test_assert_check_empty_low_leaf:
// An all-zero low leaf should be valid. It could be used as the first dummy leaf in a tree.
// It's not possible to prove against an empty leaf at an uninitialized index.
// The membership check will fail because the leaf value hash(0, 0) is not 0.

[sirasistant]

I think we prime the indexed trees in typescript with some initial leaves avoiding the all-zero leaf 🤔

[LeilaWang]

Yeah the prefilledSize is greater than 1 in real world so there won't be an all-zero leaf. But its default value is 1, so we can still consider the possibility here that there might just be 1 all-zero leaf in the tree. And this assumption is not adding more constraints so we should be good 😂

[LeilaWang]

Remove this test because the hints builder can assume the oracle will always return a value. If everything is processed correctly, it shouldn't be requesting for an unknown nullifier.
However, the oracle will still throw if the requested nullifier does not exists.

[LeilaWang]

Private tail outputs empty state.

[LeilaWang]

Removing the checks because the kernel is producing wrong leaf slots siloed with the first storage contract address for nested calls. Will fix this in another PR to include contract address for public reads and public writes, and silo them in the circuit.

[sirasistant]

Looks good to me! It seems like the gate counter breaks completely when there is a new circuit in the workspace 🥲 Left some comments, the biggest question mark for me is if we want to update trees outside of the base rollup

[sirasistant]

I think it could be simpler if we just leave all state updates to the base rollup, so the base rollup is the only circuit that actually advances state and the previous circuits need to digest data (squashing, reading, etc) for him to only receive "what does this tx need to update in the trees?". But it's true that for private-only txs we'd always incur the cost of potentially updating the public data tree. However I don't think private only txs are going to be possible given fees, depends on the final model. But I'm guessing they'll be uncommon at least! 😄

[LeilaWang]

I think you make a good point! I'll remove the end state and keep the updating in the base rollup :)

[sirasistant]

I think we prime the indexed trees in typescript with some initial leaves avoiding the all-zero leaf 🤔

[sirasistant]

the bn254 module in std::field::bn254 has an assert_gt that should be more efficient in constraints than asserting an lt, with the downside of it not supporting an assertion message

[sirasistant]

New gate counts:

{
   "programs":[
      {
         "name":"parity_base",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":480,
               "circuit_size":79811
            }
         ]
      },
      {
         "name":"private_kernel_tail",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":204606,
               "circuit_size":553261
            }
         ]
      },
      {
         "name":"public_kernel_app_logic_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":1311,
               "circuit_size":2625
            }
         ]
      },
      {
         "name":"public_kernel_teardown",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":55600,
               "circuit_size":267307
            }
         ]
      },
      {
         "name":"rollup_merge",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":363,
               "circuit_size":45970
            }
         ]
      },
      {
         "name":"rollup_base",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":171183,
               "circuit_size":1723126
            }
         ]
      },
      {
         "name":"private_kernel_init_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":854,
               "circuit_size":1711
            }
         ]
      },
      {
         "name":"private_kernel_inner",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":96574,
               "circuit_size":523866
            }
         ]
      },
      {
         "name":"public_kernel_setup_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":1311,
               "circuit_size":2625
            }
         ]
      },
      {
         "name":"public_kernel_app_logic",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":67542,
               "circuit_size":339749
            }
         ]
      },
      {
         "name":"public_kernel_tail_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":254,
               "circuit_size":511
            }
         ]
      },
      {
         "name":"rollup_base_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":1,
               "circuit_size":36
            }
         ]
      },
      {
         "name":"rollup_root",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":937,
               "circuit_size":77898
            }
         ]
      },
      {
         "name":"private_kernel_init",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":49284,
               "circuit_size":348985
            }
         ]
      },
      {
         "name":"private_kernel_tail_to_public_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":1311,
               "circuit_size":2625
            }
         ]
      },
      {
         "name":"public_kernel_setup",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":55450,
               "circuit_size":267157
            }
         ]
      },
      {
         "name":"public_kernel_teardown_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":1311,
               "circuit_size":2625
            }
         ]
      },
      {
         "name":"public_kernel_tail",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":379400,
               "circuit_size":1351057
            }
         ]
      },
      {
         "name":"parity_root",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":480,
               "circuit_size":79811
            }
         ]
      },
      {
         "name":"private_kernel_inner_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":854,
               "circuit_size":1711
            }
         ]
      },
      {
         "name":"private_kernel_tail_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":254,
               "circuit_size":511
            }
         ]
      },
      {
         "name":"private_kernel_tail_to_public",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":426171,
               "circuit_size":1006177
            }
         ]
      }
   ],
}

[sirasistant]

Master gate counts:

{
   "programs":[
      {
         "name":"parity_root",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":480,
               "circuit_size":79811
            }
         ]
      },
      {
         "name":"private_kernel_inner",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":96574,
               "circuit_size":523866
            }
         ]
      },
      {
         "name":"public_kernel_setup_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":1311,
               "circuit_size":2625
            }
         ]
      },
      {
         "name":"public_kernel_app_logic_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":1311,
               "circuit_size":2625
            }
         ]
      },
      {
         "name":"public_kernel_teardown",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":55600,
               "circuit_size":267307
            }
         ]
      },
      {
         "name":"public_kernel_tail_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":242,
               "circuit_size":487
            }
         ]
      },
      {
         "name":"rollup_merge",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":363,
               "circuit_size":45970
            }
         ]
      },
      {
         "name":"rollup_base_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":1,
               "circuit_size":36
            }
         ]
      },
      {
         "name":"rollup_root",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":937,
               "circuit_size":77898
            }
         ]
      },
      {
         "name":"private_kernel_init_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":854,
               "circuit_size":1711
            }
         ]
      },
      {
         "name":"private_kernel_tail",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":204594,
               "circuit_size":553237
            }
         ]
      },
      {
         "name":"public_kernel_app_logic",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":67542,
               "circuit_size":339749
            }
         ]
      },
      {
         "name":"rollup_base",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":171136,
               "circuit_size":1723080
            }
         ]
      },
      {
         "name":"parity_base",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":480,
               "circuit_size":79811
            }
         ]
      },
      {
         "name":"private_kernel_inner_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":854,
               "circuit_size":1711
            }
         ]
      },
      {
         "name":"private_kernel_tail_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":242,
               "circuit_size":487
            }
         ]
      },
      {
         "name":"private_kernel_tail_to_public",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":426171,
               "circuit_size":1006177
            }
         ]
      },
      {
         "name":"private_kernel_init",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":49284,
               "circuit_size":348985
            }
         ]
      },
      {
         "name":"private_kernel_tail_to_public_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":1311,
               "circuit_size":2625
            }
         ]
      },
      {
         "name":"public_kernel_setup",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":55450,
               "circuit_size":267157
            }
         ]
      },
      {
         "name":"public_kernel_teardown_simulated",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":1311,
               "circuit_size":2625
            }
         ]
      },
      {
         "name":"public_kernel_tail",
         "functions":[
            {
               "name":"main",
               "acir_opcodes":421348,
               "circuit_size":1039332
            }
         ]
      }
   ]
}