feat: implement canonical key registry 5609 and implement shared mutable getter from another contract 5689

[sklppy88]

Resolves #5609 and #5689

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (32): 86.5 (+537%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,832	6,844	6,832
l1_rollup_execution_gas	587,313	587,325	587,313
l2_block_processing_time_in_ms	1,458 (-3%)	5,436	10,427
note_successful_decrypting_time_in_ms	243	479 (-5%)	911 (-7%)
note_trial_decrypting_time_in_ms	46.3 (-2%)	⚠️ 86.5 (+537%)	28.5 (-69%)
l2_block_building_time_in_ms	18,175	71,277	142,448
l2_block_rollup_simulation_time_in_ms	17,929	70,422	140,767
l2_block_public_tx_process_time_in_ms	8,268	32,211	64,594

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	16,265	29,889 (-3%)
note_history_successful_decrypting_time_in_ms	1,180 (-11%)	2,305 (-3%)
note_history_trial_decrypting_time_in_ms	48.1 (-27%)	106 (+9%)
node_database_size_in_bytes	19,161,168	35,749,968
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	150	45,173	27,384
private-kernel-inner	164 (-1%)	73,608	27,384
private-kernel-ordering	119 (-1%)	53,138	41,123
base-parity	45.2 (-2%)	128	311
root-parity	7.24 (-2%)	1,244	311
base-rollup	19,107 (-1%)	110,928	957
root-rollup	47.4	4,551	821
public-kernel-app-logic	92.0 (-1%)	50,319	42,853
public-kernel-tail	377 (-1%)	159,352	7,493
merge-rollup	7.18 (-5%)	2,760	957
public-kernel-teardown	88.6	50,319	42,853
public-kernel-setup	87.1 (+1%)	50,319	42,853

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.0 (-1%)	17.7	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.639 (-1%)	0.548	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	51.6 (-1%)	81.1	261	499 (-1%)	987 (+1%)	1,982 (+2%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.529 (-1%)	0.500	0.475	0.467 (-1%)	0.469 (+1%)	0.473 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.6 (-1%)	120	380	735 (-1%)	1,470	2,957 (+2%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.536 (-1%)	0.540 (+1%)	0.515	0.507 (-1%)	0.509	0.513 (+1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	67.5
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.588

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	42,886	535,757

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	897	1,145	1,345

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,262 (-1%)	837 (-1%)	3,511

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	797 (-1%)	670 (-1%)	1,281	878	1,963 (-1%)	1,132

[benesjan]

looks fine

[benesjan]

I don't see any test that actually uses the values in registry contract. You should try to test both the positive and negative cases of constraining key freshness (for the negative one rotate nullifier key).

Also can you next time just send me either a fully finished PR (with all the tests and everything polished etc.) or if you need some guidance ask me a specific question on slack? Multiple time reviewing unfinished PRs is just time consuming not to mention that I don't know what is a mess you left behind because it's unfinished and what is an actual issue

[benesjan]

Just some nits. Feel free to merge once addressed. Great job!

[benesjan]

I would just call this register and the other function rotate_nullifier_public_key. The preimage check is an implementation detail so I don't think it makes sense to have it in func name and I think we'll always want to rotate the keys only 1 by 1 so it doesn't make sense to have generic rotate_keys function.

[sklppy88]

I like this, addressed in 2b1b5c, along with all the other feedback. Thank you 🙏