Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): race condition when making spot in multiple PRs #5798

Merged
merged 4 commits into from
Apr 17, 2024
Merged

fix(ci): race condition when making spot in multiple PRs #5798

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32a6d02
fix(ci): race condition when making multiple spot
ludamad Apr 16, 2024
36aac44
Update setup-runner.yml
ludamad Apr 17, 2024
296cac3
Merge branch 'master' into ad/fix/spot-start-race
ludamad Apr 17, 2024
8328ec6
Update setup-runner.yml
ludamad Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/setup-runner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# just for the CI job. These are specced per user and run the entire CI.
# TODO These have a persistent EBS volume that forms a fast-online docker image cache (used by Earthly), meaning
# TODO build steps that ran in previous invocations are quickly ran from cache.
name: Reusable Spot Instance and Setup Workflow
name: Setup Runner and CI
on:
workflow_call:
inputs:
Expand Down Expand Up @@ -52,9 +52,12 @@ on:
jobs:
start-builder:
runs-on: ubuntu-latest
# we want to avoid race conditions when making spot across multiple PRs as we only use one runner
concurrency:
group: start-builder-${{ inputs.runner_label }}
steps:
- name: Start EC2 runner
uses: AztecProtocol/ec2-action-builder@v0.10
uses: AztecProtocol/ec2-action-builder@v0.12
with:
github_token: ${{ secrets.GH_SELF_HOSTED_RUNNER_TOKEN }}
aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }}
Expand Down
Loading