Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: redo typo PR #5925

Closed
wants to merge 2 commits into from
Closed

chore: redo typo PR #5925

wants to merge 2 commits into from

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Apr 22, 2024

Thanks @dockercui for #5913. Our policy is to redo typo changes to dissuade metric farming. This is an automated script.

Signed-off-by: dockercui <dockercui@aliyun.com>
@ludamad ludamad mentioned this pull request Apr 22, 2024
@ludamad ludamad closed this Apr 22, 2024
@ludamad ludamad deleted the chore/typo-redo-20240422 branch April 22, 2024 15:32
@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • note_successful_decrypting_time_in_ms (8): 110 (-33%)
  • note_successful_decrypting_time_in_ms (32): 391 (-19%)
  • note_trial_decrypting_time_in_ms (8): 101 (+83%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 772 772 772
l1_rollup_calldata_gas 6,844 (+1%) 6,832 6,820
l1_rollup_execution_gas 587,325 587,313 587,301
l2_block_processing_time_in_ms 1,478 (-2%) 5,406 (-2%) 10,382 (-2%)
note_successful_decrypting_time_in_ms ⚠️ 110 (-33%) ⚠️ 391 (-19%) 649 (-13%)
note_trial_decrypting_time_in_ms ⚠️ 101 (+83%) 85.6 (+2%) 56.9 (+3%)
l2_block_building_time_in_ms 18,848 73,250 (-1%) 146,110 (-1%)
l2_block_rollup_simulation_time_in_ms 18,640 72,490 (-1%) 144,617 (-1%)
l2_block_public_tx_process_time_in_ms 8,533 (-1%) 33,130 (-1%) 66,731 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 16,482 (-4%) 30,638 (+1%)
note_history_successful_decrypting_time_in_ms 906 (-11%) 1,690 (+1%)
note_history_trial_decrypting_time_in_ms 120 (-14%) 117 (-2%)
node_database_size_in_bytes 19,099,728 35,815,504
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 156 47,815 31,978
private-kernel-inner 177 80,846 31,978
private-kernel-ordering 137 57,732 49,888
base-parity 71.6 (-3%) 128 265
root-parity 125 (-5%) 1,244 265
base-rollup 12,132 (-2%) 110,926 957
root-rollup 49.7 4,551 821
public-kernel-app-logic 1,668 62,069 52,067
public-kernel-tail 4,257 168,566 7,491
merge-rollup 3,123 2,760 957
public-kernel-teardown 117 62,069 52,067
public-kernel-setup 119 (+1%) 62,069 52,067

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.1 17.7 (-4%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.644 0.545 (-4%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 51.2 (-2%) 80.4 (-5%) 258 (-1%) 504 (-11%) 979 1,944 (-1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.525 (-1%) 0.496 (-5%) 0.471 (-1%) 0.471 (-11%) 0.466 0.465 (-1%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 60.6 119 (-2%) 374 (-1%) 745 (-2%) 1,467 2,915 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.536 0.536 (-1%) 0.510 0.513 (-1%) 0.509 0.508 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 67.8 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.591

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 51,450 537,961

Transaction size based on fee payment method

Metric native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 897 1,145 1,345

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,270 (+1%) 865 (-1%) 3,504
Metric 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 835 700 (+1%) 1,367 (+1%) 915 (+1%) 2,105 (+2%) 1,182 (+2%)

ludamad added a commit that referenced this pull request Apr 22, 2024
Formalizing our policy of dissuading metrics farming through typo PRs
while accepting the contribution
Example output #5925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants