Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dynamic assertion payloads v2 #5949

Merged
merged 38 commits into from
Apr 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
f630db5
wip: first iteration of dynamic assert messages v2
sirasistant Apr 22, 2024
d42e713
wip: more dynamic assertion messages
sirasistant Apr 23, 2024
d9e2427
update serialization
sirasistant Apr 23, 2024
851b10c
uncomment units
sirasistant Apr 23, 2024
b09df18
Merge branch 'master' into arv/dynamic_assert_messages_2
sirasistant Apr 23, 2024
995cc34
various chores
sirasistant Apr 23, 2024
54ddb14
chore: lock
sirasistant Apr 23, 2024
70bfa2d
chore: serde_as
sirasistant Apr 23, 2024
b298634
chores
sirasistant Apr 23, 2024
6b9758c
added test showcasing new errors
sirasistant Apr 23, 2024
2227505
Merge branch 'master' into arv/dynamic_assert_messages_2
sirasistant Apr 23, 2024
c8d786a
refactor: use selectors instead of ids
sirasistant Apr 24, 2024
e322209
feat: try to extract static assertion messages in acir gen
sirasistant Apr 24, 2024
a120b70
Merge branch 'master' into arv/dynamic_assert_messages_2
sirasistant Apr 24, 2024
f012bca
feat: allow dynamic arrays in dynamic assertions
sirasistant Apr 24, 2024
edbe200
Merge branch 'master' into arv/dynamic_assert_messages_2
sirasistant Apr 24, 2024
e8eb085
various refactors
sirasistant Apr 24, 2024
8908419
fix constant string extraction
sirasistant Apr 24, 2024
057cda2
Merge branch 'master' into arv/dynamic_assert_messages_2
sirasistant Apr 24, 2024
52d6bda
test: fix abi type
sirasistant Apr 24, 2024
6b9b559
chore: fix ts
sirasistant Apr 24, 2024
10249e3
Merge branch 'master' into arv/dynamic_assert_messages_2
sirasistant Apr 24, 2024
9dac4fb
Merge branch 'master' into arv/dynamic_assert_messages_2
sirasistant Apr 24, 2024
85fe2d5
Merge branch 'master' into arv/dynamic_assert_messages_2
sirasistant Apr 24, 2024
910b964
chore: address PR comments
sirasistant Apr 25, 2024
8f56a5b
Merge branch 'arv/dynamic_assert_messages_2' of github.com:AztecProto…
sirasistant Apr 25, 2024
f8bdaed
Merge branch 'master' into arv/dynamic_assert_messages_2
sirasistant Apr 25, 2024
cf251fe
address PR comments
sirasistant Apr 25, 2024
9593a3c
address pr comments
sirasistant Apr 25, 2024
78bf61a
Merge branch 'master' into arv/dynamic_assert_messages_2
sirasistant Apr 25, 2024
d3a67d6
address some PR comments
sirasistant Apr 26, 2024
d53eac4
refactor: remove fmtstring from ABI type
sirasistant Apr 26, 2024
da23011
test: added explicit error struct in test
sirasistant Apr 26, 2024
46d858e
Merge branch 'master' into arv/dynamic_assert_messages_2
sirasistant Apr 26, 2024
b1e5a32
chore: fix type
sirasistant Apr 26, 2024
45cbb2e
refactor
sirasistant Apr 26, 2024
2c9053a
chore: move conversion to printable type to a From impl
sirasistant Apr 26, 2024
1b2224c
Merge branch 'master' into arv/dynamic_assert_messages_2
sirasistant Apr 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions avm-transpiler/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 4 additions & 7 deletions avm-transpiler/src/transpile.rs
Original file line number Diff line number Diff line change
Expand Up @@ -251,19 +251,16 @@ pub fn brillig_to_avm(brillig_bytecode: &[BrilligOpcode]) -> Vec<u8> {
..Default::default()
});
}
BrilligOpcode::Trap {
revert_data_offset,
revert_data_size,
} => {
BrilligOpcode::Trap { revert_data } => {
avm_instrs.push(AvmInstruction {
opcode: AvmOpcode::REVERT,
indirect: Some(ALL_DIRECT),
indirect: Some(ZEROTH_OPERAND_INDIRECT),
operands: vec![
AvmOperand::U32 {
value: *revert_data_offset as u32,
value: revert_data.pointer.0 as u32,
},
AvmOperand::U32 {
value: *revert_data_size as u32,
value: revert_data.size as u32,
},
],
..Default::default()
Expand Down
Loading
Loading