chore: purge unconstrained + batch simulate improvements

[Thunkar]

Recovers work done by @LHerskind in #5819 combining it with batched simulations to avoid 💀 ⏳ in tests

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_proving_time_in_ms (private-kernel-tail): 35,679 (-20%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256	5,715	1,549	711	759 (-3%)	774

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,428	9,476	9,476
l1_rollup_execution_gas	616,069	616,117	616,117
l2_block_processing_time_in_ms	1,287 (+1%)	4,810 (+2%)	9,517
l2_block_building_time_in_ms	46,916 (+3%)	185,883 (+3%)	371,472 (+1%)
l2_block_rollup_simulation_time_in_ms	46,745 (+3%)	185,257 (+3%)	370,233 (+1%)
l2_block_public_tx_process_time_in_ms	24,966 (+2%)	103,715 (+3%)	213,430 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	9,489 (-2%)	14,443 (-2%)
node_database_size_in_bytes	14,528,592	21,364,816
pxe_database_size_in_bytes	18,071	29,868

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	164 (+1%)	3,735 (+8%)	22,032 (-9%)	20,630	64,614	89,536	2,731	1,048,576
private-kernel-inner	636 (+3%)	4,300 (+8%)	48,054 (-7%)	92,318	64,614	89,536	2,731	2,097,152
private-kernel-tail	547 (+1%)	2,935 (+8%)	⚠️ 35,679 (-20%)	90,237	77,498	10,656	266	2,097,152
base-parity	6.47 (+1%)	1,201 (+4%)	2,913 (+5%)	128	64.0	2,208	2.00	131,072
root-parity	49.8 (+3%)	61.2 (-25%)	43,580 (-14%)	27,084	64.0	2,720	18.0	2,097,152
base-rollup	796	2,347 (-2%)	74,561 (-11%)	119,610	756	3,648	47.0	4,194,304
root-rollup	114 (+2%)	66.1 (-10%)	19,464 (-10%)	25,297	620	3,456	41.0	1,048,576
public-kernel-app-logic	525 (+1%)	2,835 (+1%)	47,141 (-8%)	104,941	86,302	114,784	3,520	2,097,152
public-kernel-tail	1,191 (+1%)	22,556	154,855 (-12%)	395,386	7,522	10,656	266	8,388,608
private-kernel-reset-small	597 (+2%)	2,176 (+7%)	43,248 (-11%)	120,733	64,614	89,536	2,731	2,097,152
merge-rollup	28.5 (-1%)	N/A	N/A	16,534	756	N/A	N/A	N/A
public-kernel-setup	698 (+13%)	N/A	N/A	104,941	86,302	N/A	N/A	N/A
public-kernel-teardown	531 (+2%)	N/A	N/A	104,941	86,302	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,615 (+5%)	82,785 (-11%)	N/A	N/A	114,784	3,520	4,194,304

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,944	470 (+4%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,944	42.2 (+4%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,944	1,477 (+5%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,944	1,023 (+3%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,944	2,133 (+2%)	16,768	46,046 (-8%)	2,097,152	457
Token:privately_mint_private_note	1,280	9,944	1,170 (+6%)	N/A	N/A	N/A	N/A
Token:transfer	1,376	9,944	4,207 (+5%)	16,768	53,556 (-4%)	2,097,152	457
Benchmarking:create_note	1,312	9,944	982 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,944	228	N/A	N/A	N/A	N/A
SchnorrAccount:spend_private_authwit	1,280	9,944	76.9 (-1%)	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,944	3,284 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,944	4,078 (+1%)	N/A	N/A	N/A	N/A

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.7 (+3%)	17.2 (+2%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.620 (+4%)	0.527 (+2%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	49.3 (+2%)	75.8	245 (+3%)	475 (-1%)	927 (+3%)	1,834	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.504 (+2%)	0.468	0.445 (+3%)	0.443 (-1%)	0.439 (+3%)	0.438	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	58.4 (+1%)	112 (+1%)	354 (+3%)	699 (-1%)	1,382 (+2%)	2,747	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	106	208	692	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.506 (+1%)	0.504 (+1%)	0.481 (+3%)	0.480 (-1%)	0.479 (+2%)	0.478	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	62.4 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	107
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.553 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	83,794	665,117

Transaction size based on fee payment method

| Metric | |
| - | |

[LHerskind]

Mainly that we could use static for the getters 👀

[LHerskind]

Don't love this, works when we have just one wallet, but with multiple as we will need in escrow it gets funky, think we could set a default when we are constructing or something 🤷, But I can deal with that at the escrow instead.

Think we might also run into some issues if we are moving towards more calls than what a single batch can handle, or will it already be handled in the batch 🤔

[Thunkar]

Haven't seen the escrow yet, was planning to check it out in a different PR to avoid merge hell, but yeah, it won't work with different wallets interacting (this was mainly to get it working and see if the time was somewhat reasonable)

The batching doesn't handle +4 fns per tx, we have to do it externally (we have just been lucky for the time being, but creating a private getter insteat of the current unconstrained will make it blow up). I can do it now if we anticipate the check function to be called with +4 constrained calls.

[Thunkar]

Fixed the batching for mixing public/private and tested it by jerry-rigging the token test to do a bunch of calls that I had to split into multiple transactions.

I'll leave the escrowing shenanigans to you ❤️