Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avm): pedersen ops #6765

Merged
merged 6 commits into from
May 30, 2024
Merged

feat(avm): pedersen ops #6765

merged 6 commits into from
May 30, 2024

Conversation

IlyasRidhuan
Copy link
Contributor

Please read contributing guidelines and remove this line.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @IlyasRidhuan and the rest of your teammates on Graphite Graphite

@IlyasRidhuan IlyasRidhuan marked this pull request as ready for review May 30, 2024 12:31
@AztecBot
Copy link
Collaborator

AztecBot commented May 30, 2024

Benchmark results

Metrics with a significant change:

  • protocol_circuit_witness_generation_time_in_ms (base-parity): 884 (-18%)
  • protocol_circuit_witness_generation_time_in_ms (root-parity): 64.1 (+37%)
  • protocol_circuit_proving_time_in_ms (private-kernel-tail-to-public): 101,417 (+17%)
  • protocol_circuit_proving_time_in_ms (base-rollup): 78,163 (+21%)
  • protocol_circuit_proving_time_in_ms (public-kernel-setup): 44,499 (+18%)
  • protocol_circuit_proving_time_in_ms (root-parity): 40,366 (+19%)
  • protocol_circuit_proving_time_in_ms (public-kernel-app-logic): 47,775 (+23%)
  • protocol_circuit_proving_time_in_ms (public-kernel-teardown): 45,739 (+17%)
  • protocol_circuit_proving_time_in_ms (public-kernel-tail): 179,607 (+16%)
  • protocol_circuit_proving_time_in_ms (root-rollup): 24,209 (+24%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,803 (+1%) 1,577 (+1%) 719 (+1%) 768 (+1%) 785 (+1%)
proof_construction_time_sha256_30_ms 11,824 (+3%) 3,167 (+2%) 1,396 1,446 (+2%) 1,468
proof_construction_time_sha256_100_ms 45,069 (+2%) 12,147 (+1%) 5,793 (+3%) 5,606 (+1%) 5,462
proof_construction_time_poseidon_hash_ms 79.0 (+1%) 34.0 34.0 58.0 87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms 1,534 (+1%) 421 (+1%) 200 223 (-3%) 267 (-1%)
proof_construction_time_poseidon_hash_100_ms 5,843 (+2%) 1,591 (+1%) 732 (+1%) 787 812 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 1,412 1,412 1,412
l1_rollup_calldata_gas 9,428 9,476 9,464
l1_rollup_execution_gas 616,069 616,117 616,105
l2_block_processing_time_in_ms 1,283 4,791 9,460 (-1%)
l2_block_building_time_in_ms 43,940 (-2%) 173,487 (-2%) 347,037 (-1%)
l2_block_rollup_simulation_time_in_ms 43,746 (-2%) 172,760 (-2%) 345,609 (-1%)
l2_block_public_tx_process_time_in_ms 38,018 (-2%) 169,395 (-1%) 339,732 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 9,363 (-1%) 14,279 (-1%)
node_database_size_in_bytes 14,504,016 21,307,472
pxe_database_size_in_bytes 18,071 29,868

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms proving_time_in_ms input_size_in_bytes output_size_in_bytes proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 134 (-1%) 471 (-6%) 13,411 (+12%) 20,634 64,614 89,536 2,731 524,288
private-kernel-inner 411 (+1%) 1,093 (+8%) 50,322 (+11%) 92,326 64,614 89,536 2,731 2,097,152
private-kernel-tail 581 (-1%) 2,676 (-7%) 54,466 (+15%) 96,545 77,732 11,648 297 2,097,152
base-parity 6.45 (-1%) ⚠️ 884 (-18%) 3,042 (+9%) 128 64.0 2,208 2.00 131,072
root-parity 49.2 (-2%) ⚠️ 64.1 (+37%) ⚠️ 40,366 (+19%) 27,100 64.0 2,720 18.0 2,097,152
base-rollup 9,148 2,441 (+4%) ⚠️ 78,163 (+21%) 119,738 756 3,648 47.0 4,194,304
root-rollup 110 (-2%) 80.4 (+22%) ⚠️ 24,209 (+24%) 25,309 620 3,456 41.0 1,048,576
public-kernel-app-logic 577 (+1%) 3,662 (+3%) ⚠️ 47,775 (+23%) 108,073 86,550 116,768 3,582 2,097,152
public-kernel-tail 1,124 (-1%) 25,352 (+7%) ⚠️ 179,607 (+16%) 403,238 7,646 11,648 297 8,388,608
private-kernel-reset-small 587 (-1%) 2,040 (-4%) 45,782 (+12%) 120,737 64,614 89,536 2,731 2,097,152
public-kernel-setup 673 (+1%) 2,808 (+5%) ⚠️ 44,499 (+18%) 108,073 86,550 116,768 3,582 2,097,152
public-kernel-teardown 582 (-1%) 3,626 (+2%) ⚠️ 45,739 (+17%) 108,073 86,550 116,768 3,582 2,097,152
merge-rollup 33.0 (+2%) N/A N/A 16,542 756 N/A N/A N/A
private-kernel-tail-to-public N/A 8,683 (-1%) ⚠️ 101,417 (+17%) N/A N/A 116,768 3,582 4,194,304

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms size_in_gates num_public_inputs
ContractClassRegisterer:register 1,344 9,944 463 N/A N/A N/A N/A
ContractInstanceDeployer:deploy 1,408 9,944 42.4 (+1%) N/A N/A N/A N/A
MultiCallEntrypoint:entrypoint 1,920 9,944 1,791 N/A N/A N/A N/A
SchnorrAccount:constructor 1,312 9,944 1,430 (-2%) N/A N/A N/A N/A
SchnorrAccount:entrypoint 2,304 9,944 2,845 (+4%) 16,768 55,827 (+11%) 2,097,152 457
Token:privately_mint_private_note 1,280 9,944 1,573 (-5%) N/A N/A N/A N/A
FPC:fee_entrypoint_public 1,344 9,944 1,044 (-8%) 16,768 11,067 (+10%) 524,288 457
Token:transfer 1,376 9,944 5,357 (-1%) 16,768 52,802 (+10%) 2,097,152 457
Benchmarking:create_note 1,344 9,944 1,390 N/A N/A N/A N/A
SchnorrAccount:spend_private_authwit 1,280 9,944 76.4 (-1%) N/A N/A N/A N/A
Token:unshield 1,376 9,944 3,928 (+1%) N/A N/A N/A N/A
FPC:fee_entrypoint_private 1,376 9,944 4,820 N/A N/A N/A N/A

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.4 (-1%) 16.8 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.602 (-1%) 0.515 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 48.2 (-1%) 76.0 247 472 (-1%) 925 1,817 (-1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.492 (-1%) 0.468 0.448 0.440 (-1%) 0.438 0.433 (-1%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 57.9 (-1%) 112 356 694 (-1%) 1,379 2,724 (-1%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 106 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.501 (-1%) 0.502 0.483 0.477 0.478 0.472 (-1%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 62.3 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 107
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.550 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 84,053 665,267

Transaction size based on fee payment method

| Metric | |
| - | |

Copy link
Contributor

@jeanmon jeanmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please look at the comments.

@jeanmon jeanmon enabled auto-merge (squash) May 30, 2024 16:15
@jeanmon jeanmon disabled auto-merge May 30, 2024 16:33
@Maddiaa0 Maddiaa0 enabled auto-merge (squash) May 30, 2024 16:48
@Maddiaa0 Maddiaa0 merged commit 7b3a72c into master May 30, 2024
87 of 91 checks passed
@Maddiaa0 Maddiaa0 deleted the 05-28-feat_avm_pedersen_ops branch May 30, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants