Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete spike vm #6818

Merged
merged 1 commit into from
Jun 2, 2024
Merged

chore: delete spike vm #6818

merged 1 commit into from
Jun 2, 2024

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Jun 2, 2024

The functionality for this is now fully in the avm, so we no longer need it to ensure no breakage

Copy link
Member Author

Maddiaa0 commented Jun 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Maddiaa0 and the rest of your teammates on Graphite Graphite

@Maddiaa0 Maddiaa0 force-pushed the md/06-02-chore_delete_spike_vm branch from 9136200 to 9bb1afa Compare June 2, 2024 19:13
@Maddiaa0 Maddiaa0 changed the base branch from md/kernel-outputs-executor to master June 2, 2024 19:13
@Maddiaa0 Maddiaa0 marked this pull request as ready for review June 2, 2024 19:14
@Maddiaa0 Maddiaa0 enabled auto-merge (squash) June 2, 2024 19:14
@Maddiaa0 Maddiaa0 merged commit 5633ee9 into master Jun 2, 2024
89 checks passed
@Maddiaa0 Maddiaa0 deleted the md/06-02-chore_delete_spike_vm branch June 2, 2024 19:55
@AztecBot
Copy link
Collaborator

AztecBot commented Jun 2, 2024

Benchmark results

Metrics with a significant change:

  • protocol_circuit_proving_time_in_ms (private-kernel-tail): 51,234 (-16%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,701 1,547 698 768 (+3%) 776
proof_construction_time_sha256_30_ms 11,782 (+1%) 3,145 1,404 1,421 (-1%) 1,463
proof_construction_time_sha256_100_ms 44,503 12,036 5,647 5,546 5,477 (-1%)
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 57.0 88.0
proof_construction_time_poseidon_hash_30_ms 1,516 417 201 224 (-1%) 267 (-1%)
proof_construction_time_poseidon_hash_100_ms 5,717 1,561 (+1%) 723 784 790

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 1,412 1,412 1,412
l1_rollup_calldata_gas 9,440 9,476 9,476
l1_rollup_execution_gas 607,976 608,012 608,012
l2_block_processing_time_in_ms 1,286 4,819 9,596
l2_block_building_time_in_ms 44,465 (+1%) 175,188 349,649
l2_block_rollup_simulation_time_in_ms 44,267 (+1%) 174,459 348,206
l2_block_public_tx_process_time_in_ms 41,036 (+1%) 171,137 344,907

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 9,522 (+3%) 14,518 (+1%)
node_database_size_in_bytes 14,463,056 21,373,008
pxe_database_size_in_bytes 18,071 29,868

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms proving_time_in_ms input_size_in_bytes output_size_in_bytes proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 137 546 (+13%) 13,141 (-3%) 20,634 64,614 89,536 2,731 524,288
private-kernel-inner 408 985 (-7%) 50,284 (-12%) 92,326 64,614 89,536 2,731 2,097,152
private-kernel-tail 588 (+1%) 2,989 (+10%) ⚠️ 51,234 (-16%) 96,545 77,732 11,648 297 2,097,152
base-parity 6.47 1,734 (+3%) 2,824 (+2%) 128 64.0 2,208 2.00 131,072
root-parity 49.5 (+1%) 69.0 (+2%) 40,460 (-7%) 27,100 64.0 2,720 18.0 2,097,152
base-rollup 12,088 (+2%) 2,446 (-3%) 79,408 (-9%) 119,738 756 3,648 47.0 4,194,304
root-rollup 111 (+2%) 79.8 (-2%) 23,973 (-4%) 25,309 620 3,456 41.0 1,048,576
public-kernel-app-logic 571 (+1%) 3,625 (-4%) 45,907 (-5%) 108,073 86,550 116,768 3,582 2,097,152
public-kernel-tail 1,127 (+1%) 24,792 186,885 (-8%) 403,238 7,646 11,648 297 8,388,608
private-kernel-reset-small 593 1,943 (-1%) 45,762 (-12%) 120,737 64,614 89,536 2,731 2,097,152
public-kernel-setup 669 2,805 (-3%) 44,377 (-4%) 108,073 86,550 116,768 3,582 2,097,152
public-kernel-teardown 577 (+1%) 3,624 (-4%) 46,770 (-4%) 108,073 86,550 116,768 3,582 2,097,152
merge-rollup 28.9 (+1%) N/A N/A 16,542 756 N/A N/A N/A
private-kernel-tail-to-public N/A 8,514 (-13%) 105,308 (-8%) N/A N/A 116,768 3,582 4,194,304

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms size_in_gates num_public_inputs
ContractClassRegisterer:register 1,344 9,944 462 N/A N/A N/A N/A
ContractInstanceDeployer:deploy 1,408 9,944 41.4 (+1%) N/A N/A N/A N/A
MultiCallEntrypoint:entrypoint 1,920 9,944 1,768 (+1%) N/A N/A N/A N/A
SchnorrAccount:constructor 1,312 9,944 1,428 N/A N/A N/A N/A
SchnorrAccount:entrypoint 2,304 9,944 2,742 16,768 56,006 (-8%) 2,097,152 457
Token:privately_mint_private_note 1,280 9,944 1,575 (-1%) N/A N/A N/A N/A
FPC:fee_entrypoint_public 1,344 9,944 1,043 16,768 11,070 (-5%) 524,288 457
Token:transfer 1,376 9,944 5,358 (+1%) 16,768 54,159 (-11%) 2,097,152 457
Benchmarking:create_note 1,344 9,944 1,393 (+1%) N/A N/A N/A N/A
SchnorrAccount:spend_private_authwit 1,280 9,944 88.3 (+15%) N/A N/A N/A N/A
Token:unshield 1,376 9,944 3,975 (+2%) N/A N/A N/A N/A
FPC:fee_entrypoint_private 1,376 9,944 4,868 (+2%) N/A N/A N/A N/A

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.5 17.4 (+1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.605 0.522 (+1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 48.8 (+1%) 78.0 (+2%) 246 (-1%) 479 (+2%) 929 (-1%) 1,847 (-1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.497 (+1%) 0.480 (+2%) 0.446 (-1%) 0.446 (+2%) 0.440 (-1%) 0.440 (-1%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 58.5 (+1%) 113 355 (-1%) 704 (+2%) 1,386 (-1%) 2,759 (-1%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 106 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.505 (+1%) 0.505 0.482 (-1%) 0.483 (+2%) 0.479 (-1%) 0.478 (-1%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 62.9 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 107
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.555 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 84,053 665,267

Transaction size based on fee payment method

| Metric | |
| - | |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants