feat: Sync from noir

[AztecBot]

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: avoid bn254_blackbox_solver polluting feature flags (noir-lang/noir#5141)
chore!: remove distinct keyword (noir-lang/noir#5219)
feat: Sync from aztec-packages (noir-lang/noir#5222)
chore: add some property tests to ACVM crates (noir-lang/noir#5215)
chore: inline FieldElement.is_negative and document (noir-lang/noir#5214)
chore!: remove param_witnesses and return_witnesses from ABI (noir-lang/noir#5154)
chore: move implementation of bitwise operations into blackbox_solver (noir-lang/noir#5209)
chore: remove stale comment (noir-lang/noir#5179)
chore: make nargo crate and debug info generic (noir-lang/noir#5184)
feat!: add session id to foreign call RPC requests (noir-lang/noir#5205)
chore(docs): fix incorrect docs github link in footer (noir-lang/noir#5206)
fix: error for allocate instructions in acir-gen (noir-lang/noir#5200)
feat: Implement println in the comptime interpreter (noir-lang/noir#5197)
chore(docs): Supplement Noir Debugger's dependency versions (noir-lang/noir#5199)
chore(docs): Update docs homepage (noir-lang/noir#5198)
chore: add more lints related to oracle calls (noir-lang/noir#5193)
feat: standardize pedersen functions to return EmbeddedCurvePoint (noir-lang/noir#5190)
END_COMMIT_OVERRIDE

[TomAFrench]

Note that I reverted a change from noir-lang/noir in 14df10d

[vezenovm]

Note that I reverted a change from noir-lang/noir in 14df10d

The follow-up sync brought it back

[vezenovm]

This is just fmt, and the same thing for the aztec-nr changes.

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_sha256_30_ms (16): 1,695 (+24%)
• protocol_circuit_witness_generation_time_in_ms (private-kernel-tail-to-public): 8,863 (+22%)
• protocol_circuit_witness_generation_time_in_ms (root-parity): 65.9 (+38%)
• protocol_circuit_proving_time_in_ms (private-kernel-tail): 54,953 (+20%)
• protocol_circuit_proving_time_in_ms (private-kernel-tail-to-public): 100,677 (+18%)
• protocol_circuit_proving_time_in_ms (base-rollup): 87,101 (+20%)
• protocol_circuit_proving_time_in_ms (root-parity): 40,619 (+19%)
• protocol_circuit_proving_time_in_ms (public-kernel-setup): 46,181 (+20%)
• protocol_circuit_proving_time_in_ms (public-kernel-teardown): 49,232 (+24%)
• protocol_circuit_proving_time_in_ms (public-kernel-tail): 194,104 (+22%)
• protocol_circuit_proving_time_in_ms (root-rollup): 23,865 (+22%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_30_ms	11,385	3,086 (+1%)	⚠️ 1,695 (+24%)	1,409 (-1%)	1,450 (-1%)
proof_construction_time_sha256_100_ms	43,742	11,765	5,408	5,425 (+1%)	5,333
proof_construction_time_poseidon_hash_ms	79.0	34.0	34.0	57.0 (-2%)	88.0
proof_construction_time_poseidon_hash_30_ms	1,518	416	199	222 (-3%)	268
proof_construction_time_poseidon_hash_100_ms	5,747	1,565	724	783 (+1%)	796

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,464	9,452	9,440
l1_rollup_execution_gas	610,285	610,273	610,261
l2_block_processing_time_in_ms	747 (-1%)	1,402 (-1%)	2,685
l2_block_building_time_in_ms	22,920 (-1%)	45,553 (-2%)	89,894 (-1%)
l2_block_rollup_simulation_time_in_ms	22,828 (-1%)	45,265 (-2%)	89,559 (-1%)
l2_block_public_tx_process_time_in_ms	19,577 (-1%)	41,831 (-2%)	86,145 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	6,374 (-2%)	9,218 (-1%)
node_database_size_in_bytes	10,559,568	14,418,000
pxe_database_size_in_bytes	9,242	15,127

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	131 (+1%)	481 (-4%)	13,255 (+7%)	20,634	65,142	90,304	2,755	524,288
private-kernel-inner	387 (-1%)	951 (-6%)	50,254 (+11%)	92,854	65,142	90,304	2,755	2,097,152
private-kernel-tail	370	1,872 (-1%)	⚠️ 54,953 (+20%)	97,073	73,629	14,912	399	2,097,152
base-parity	6.36 (-1%)	1,759 (-6%)	2,876 (+11%)	128	64.0	2,208	2.00	131,072
root-parity	50.0 (-2%)	⚠️ 65.9 (+38%)	⚠️ 40,619 (+19%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	7,662 (-1%)	4,400 (-2%)	⚠️ 87,101 (+20%)	170,330	756	3,648	47.0	4,194,304
root-rollup	112 (-1%)	79.3 (+21%)	⚠️ 23,865 (+22%)	25,309	620	3,456	41.0	1,048,576
public-kernel-setup	704 (-1%)	2,976 (+4%)	⚠️ 46,181 (+20%)	113,321	91,286	123,296	3,786	2,097,152
public-kernel-app-logic	589 (-1%)	3,878 (-2%)	45,757 (+15%)	113,321	91,286	123,296	3,786	2,097,152
public-kernel-tail	1,173 (-1%)	34,371 (+6%)	⚠️ 194,104 (+22%)	412,582	10,014	14,912	399	8,388,608
private-kernel-reset-small	587 (-1%)	2,112	46,300 (+14%)	121,265	65,142	90,304	2,755	2,097,152
public-kernel-teardown	604	3,926 (+1%)	⚠️ 49,232 (+24%)	113,321	91,286	123,296	3,786	2,097,152
merge-rollup	29.0 (-2%)	N/A	N/A	16,542	756	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	⚠️ 8,863 (+22%)	⚠️ 100,677 (+18%)	N/A	N/A	123,296	3,786	4,194,304
avm-circuit	N/A	N/A	3,569 (+13%)	N/A	N/A	86,117	0.00	0.00

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,944	407	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,944	40.6 (-2%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,944	1,985 (-1%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	9,944	960 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,944	1,437 (-2%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,944	2,799 (-1%)	16,768	55,862 (+10%)	2,097,152	457
Token:privately_mint_private_note	1,280	9,944	1,678 (-4%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,944	355 (-3%)	16,768	11,088 (+10%)	524,288	457
Token:transfer	1,312	9,944	4,907	16,768	52,612 (+14%)	2,097,152	457
Benchmarking:create_note	1,344	9,944	1,396 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:spend_private_authwit	1,280	9,944	77.1 (+2%)	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,944	4,051 (+2%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,944	5,005 (+2%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	70.7 (+1%)	13,873
GasToken:set_portal	18.0 (+9%)	3,495
Token:constructor	95.4 (+1%)	24,207
FPC:constructor	62.4 (-3%)	13,893
GasToken:mint_public	53.4 (-2%)	10,241
Token:mint_public	560 (+2%)	19,216
Token:assert_minter_and_mint	75.3 (+1%)	13,034
SchnorrAccount:approve_public_authwit	33.2 (+5%)	7,767
FPC:prepare_fee	85.6 (+15%)	15,187
Token:transfer_public	62.8 (+22%)	31,236
FPC:pay_refund	68.3 (+4%)	20,080
Benchmarking:increment_balance	2,390 (-1%)	15,465
Token:_increase_public_balance	60.2 (-16%)	15,089
FPC:pay_refund_with_shielded_rebate	53.6 (+6%)	21,167

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.181 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.3	16.8 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.599 (-1%)	0.515 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.4	75.3 (-1%)	131	243 (-2%)	466
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	288	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.494	0.464 (-1%)	0.448	0.441 (-1%)	0.437
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.3 (-1%)	111 (-1%)	180 (-1%)	351 (-1%)	690
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	208	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.503 (-1%)	0.499	0.476 (-1%)	0.476 (-1%)	0.475
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	74.3 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	135	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.519 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	83,854	676,749

Transaction size based on fee payment method

| Metric | |
| - | |