-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: private tail circuits #7148
Merged
Merged
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
d017c95
Build hints for private init in noir.
LeilaWang 304e5b9
Build private tail hints in noir.
LeilaWang 609af30
Merge remote-tracking branch 'origin/master' into lw/build_hints_in_noir
LeilaWang b9c2823
Update type.
LeilaWang 3050229
Private tail to public output composer.
LeilaWang 3d921ca
Merge remote-tracking branch 'origin/master' into lw/build_hints_in_noir
LeilaWang c089385
Verify the output of private_tail_to_public against previous kernel.
LeilaWang b91742f
Move util.
LeilaWang c2435ef
Test tail circuits in constrained mode to run output validator.
LeilaWang af8f82f
Fix test.
LeilaWang a4ae476
Merge remote-tracking branch 'origin/master' into lw/build_hints_in_noir
LeilaWang 86bfffe
Remove hints for private tail circuit from ts.
LeilaWang 59dbfa3
Revert changes to public call stack.
LeilaWang 1afa3fd
Reverse public call requests.
LeilaWang 201c1b4
Update fixture.
LeilaWang c2b19a4
Increase timeout.
LeilaWang e7ba8bc
Add script for generating flamegraph.
LeilaWang e510c66
Merge remote-tracking branch 'origin/master' into lw/build_hints_in_noir
LeilaWang 267516c
Rename files.
LeilaWang e1252ba
Update assert_split_sorted_transformed_value_arrays and tests.
LeilaWang 5828970
Merge remote-tracking branch 'origin/master' into lw/build_hints_in_noir
LeilaWang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 4 additions & 3 deletions
7
noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/components.nr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
mod kernel_circuit_output_hints; | ||
mod kernel_circuit_output_validator; | ||
mod kernel_circuit_public_inputs_composer; | ||
mod previous_kernel_validator; | ||
mod private_call_data_validator; | ||
mod private_kernel_circuit_output_validator; | ||
mod private_kernel_circuit_public_inputs_composer; | ||
mod tail_output_composer; | ||
mod tail_output_validator; | ||
mod tail_to_public_output_composer; | ||
mod tail_to_public_output_validator; |
254 changes: 0 additions & 254 deletions
254
...ircuits/crates/private-kernel-lib/src/components/kernel_circuit_public_inputs_composer.nr
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort and silo values in
private_kernel_circuit_public_input_composer.nr
.