refactor: nuking "new" from names

[benesjan]

With Leila's big PR being merged this got unblocked. See this discussion for context.

Note: The changes were mechanical so I don't think the review has to be thorough.

[benesjan]

• feat: noncifying public note hashes #7293
• refactor: nuking "new" from names #7273 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Docs Preview

Hey there! 👋 You can check your preview at https://6684f745990b899845238296--aztec-docs-dev.netlify.app

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 81.1 (-84%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 175 (+219%)
• avm_simulation_time_ms (Token:transfer_public): 48.3 (+53%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,720	1,549 (-1%)	707 (-1%)	746 (-6%)	780 (+1%)
proof_construction_time_sha256_30_ms	11,720 (-3%)	3,146 (-2%)	1,415 (-1%)	1,431 (-1%)	1,467 (-1%)
proof_construction_time_sha256_100_ms	43,821 (-1%)	11,722 (-2%)	5,436 (-2%)	5,403 (-1%)	5,368 (-1%)
proof_construction_time_poseidon_hash_ms	77.0 (-3%)	34.0	34.0	58.0	87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,515 (-1%)	415 (-1%)	200	228 (-1%)	267
proof_construction_time_poseidon_hash_100_ms	5,739 (-1%)	1,560 (-1%)	722 (-1%)	796 (+2%)	789 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,464	9,470	9,464
l1_rollup_execution_gas	611,203	611,360	611,505
l2_block_processing_time_in_ms	766 (+2%)	1,412	2,723 (+1%)
l2_block_building_time_in_ms	20,841	41,918	81,621
l2_block_rollup_simulation_time_in_ms	20,841	41,918	81,620
l2_block_public_tx_process_time_in_ms	17,848	38,696	78,463

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,039 (+1%)	9,810
node_database_size_in_bytes	12,226,640	16,203,856
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	102 (-1%)	395 (+3%)	12,948 (+2%)	19,482	54,134	73,920	2,243	524,288
private-kernel-inner	308	768 (+1%)	49,713 (+1%)	80,694	54,134	73,920	2,243	2,097,152
private-kernel-tail	1,084	2,539 (-1%)	49,885 (+2%)	61,457	62,057	14,912	399	2,097,152
base-parity	6.23 (+1%)	1,544 (-2%)	2,768 (+6%)	128	64.0	2,208	2.00	131,072
root-parity	48.9	71.3 (+5%)	42,172 (+7%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	6,590	4,995 (+3%)	90,534 (+3%)	170,330	728	3,648	47.0	4,194,304
root-rollup	110	82.5 (-1%)	23,721 (-4%)	25,253	620	3,456	41.0	1,048,576
public-kernel-setup	541	2,457 (+3%)	44,005 (+6%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-app-logic	500	3,456 (+6%)	44,887 (+1%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-tail	1,147	27,630 (+5%)	180,292 (+1%)	399,014	10,014	14,912	399	8,388,608
private-kernel-reset-small	469	1,101 (+2%)	31,531 (+6%)	109,233	54,134	73,920	2,243	1,048,576
public-kernel-teardown	490	3,444 (+4%)	45,387 (+2%)	102,121	80,278	106,912	3,274	2,097,152
merge-rollup	29.3	N/A	N/A	16,486	728	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,526 (+2%)	53,292	N/A	N/A	106,912	3,274	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	8,792	406 (+1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	8,792	38.9 (+1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	8,792	1,192 (+1%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	8,792	905 (+1%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	8,792	492 (+1%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	8,792	1,626	14,720	53,419 (-1%)	2,097,152	393
Token:privately_mint_private_note	1,280	8,792	638 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	8,792	271	14,720	11,734 (+4%)	524,288	393
Token:transfer	1,312	8,792	1,788	14,720	13,328 (+5%)	524,288	393
AuthRegistry:set_authorized (avm)	19,226	N/A	N/A	91,264	1,374 (+8%)	N/A	N/A
FPC:prepare_fee (avm)	26,668	N/A	N/A	91,328	3,073 (+9%)	N/A	N/A
Token:transfer_public (avm)	42,918	N/A	N/A	91,328	4,038 (+4%)	N/A	N/A
AuthRegistry:consume (avm)	33,104	N/A	N/A	91,264	3,047 (+8%)	N/A	N/A
FPC:pay_refund (avm)	36,833	N/A	N/A	91,296	23,836 (+5%)	N/A	N/A
Benchmarking:create_note	1,344	8,792	478 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	8,792	77.7 (+2%)	N/A	N/A	N/A	N/A
Token:unshield	1,376	8,792	1,575 (+3%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	8,792	2,192 (+4%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	69.0 (+1%)	13,790
GasToken:set_portal	14.7 (-24%)	3,339
Token:constructor	91.9 (-8%)	23,692
FPC:constructor	61.1 (-5%)	13,592
GasToken:mint_public	53.3 (+3%)	10,158
Token:mint_public	⚠️ 81.1 (-84%)	19,034
Token:assert_minter_and_mint	⚠️ 175 (+219%)	12,925
AuthRegistry:set_authorized	31.3 (+1%)	7,812
FPC:prepare_fee	113 (+3%)	15,062
Token:transfer_public	⚠️ 48.3 (+53%)	31,218
FPC:pay_refund	141 (+2%)	25,260
Benchmarking:increment_balance	2,200	15,267
Token:_increase_public_balance	55.2 (-1%)	15,006
FPC:pay_refund_with_shielded_rebate	123 (+5%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.155

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4 (+1%)	16.8 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.601 (+1%)	0.516 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.2	76.1 (+1%)	132 (+1%)	245	475 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.492	0.467 (+1%)	0.454 (+1%)	0.444 (+1%)	0.443 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.9 (+1%)	112 (+1%)	184 (+2%)	353 (+1%)	700 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.506 (+1%)	0.503 (+1%)	0.487 (+1%)	0.478 (+1%)	0.479 (+1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.9 (+1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.519 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,057	667,850

Transaction size based on fee payment method

| Metric | |
| - | |

[dbanks12]

You'll need to run ./compile_avm.sh to regenerate C++ code after this change. We'll try to improve this tooling.

[benesjan]

The script seems to be broken:

% ./compile_avm.sh
./compile_avm.sh: line 4: ../../bb-pilcom/target/release/bb_pil: No such file or directory
% 

and when I tried fixing that by changing the content to:

#!/bin/bash

# Compile
../../../bb-pilcom/target/release/bb_pil pil/avm/main.pil --name Avm

I got:

% ./compile_avm.sh
thread 'main' panicked at powdr/pil-analyzer/src/pil_analyzer.rs:84:29:
File "pil/avm/main.pil" not found: No such file or directory (os error 2)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[dbanks12]

Make sure to run it from barretenberg/cpp. Also note that it'll change a lot of the files, but they'll be auto-formatted when you commit them so the diff won't as big as it seems.

[benesjan]

Managed to run it and after it got formatted it didn't result in any changes b96023a

I think there were no changes in the commit because I globally replaced the constant names even in generated files. So there was nothing for the script to change.

[jeanmon]

@benesjan It is normal because pil constants are completely inlined (replaced by literal value) in the cpp generated relations.

[jeanmon]

I looked at the AVM related code. LGTM.

[jeanmon]

@benesjan It is normal because pil constants are completely inlined (replaced by literal value) in the cpp generated relations.