Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Build and publish cli wallet #7915

Merged
merged 2 commits into from
Aug 12, 2024
Merged

feat: Build and publish cli wallet #7915

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a64fca2
Build and publish cli wallet
PhilWindle Aug 12, 2024
a037248
Publish git sha tag
PhilWindle Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 44 additions & 54 deletions .github/workflows/devnet-deploys.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,65 +330,55 @@ jobs:

docker push aztecprotocol/aztec-faucet:${{ github.sha }}

# build-cli-wallet:
# needs: set-network
# env:
# BRANCH_NAME: ${{ needs.set-network.outputs.branch_name }}
# DEPLOY_TAG: ${{ needs.set-network.outputs.deploy_tag }}
# TF_VAR_DEPLOY_TAG: ${{ needs.set-network.outputs.deploy_tag }}
# API_KEY: ${{ secrets[needs.set-network.outputs.network_api_key] }}
# TF_VAR_API_KEY: ${{ secrets[needs.set-network.outputs.network_api_key] }}
# API_KEY_NAME: ${{ needs.set-network.outputs.network_api_key }}
# runs-on: ${{ github.actor }}-x86
# steps:
# - uses: actions/checkout@v4
# with:
# ref: "${{ env.GIT_COMMIT }}"
# fetch-depth: 0
# - uses: ./.github/ci-setup-action
# with:
# concurrency_key: build-cli-wallet-${{ github.actor }}
# dockerhub_password: "${{ env.DOCKERHUB_PASSWORD }}"
# - name: Check if only workflow flows have changed
# id: check_only_workflow_changes
# uses: actions/github-script@v7
# with:
# script: |
# const { execSync } = require('child_process');
# const changedFiles = execSync('git diff --name-only ${{ github.event.before }} ${{ github.sha }}')
# .toString()
# .split('\n')
# .filter(line => line);
# const prefixesToIgnore = ['.github', 'iac'];
# const suffixesToIgnore = ['.tf'];
# return changedFiles.every(file => (
# prefixesToIgnore.some(prefix => file.startsWith(prefix)) ||
# suffixesToIgnore.some(suffix => file.endsWith(suffix))
# ));
# - name: "Build & Push aztec images"
# timeout-minutes: 40
# if: steps.check_only_workflow_changes.outputs.result == 'false'
# run: |
# env
# earthly-ci --no-output --push ./yarn-project+export-cli-wallet --DIST_TAG=${{ env.DEPLOY_TAG }}
# earthly-ci --no-output --push ./yarn-project+export-cli-wallet --DIST_TAG=${{ github.sha }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to publish by github sha?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there is no harm in doing so


# - name: "Re-tag Aztec image"
# if: steps.check_only_workflow_changes.outputs.result == 'true'
# run: |
# env
# docker pull aztecprotocol/cli-wallet:${{ env.DEPLOY_TAG }}

# docker tag aztecprotocol/cli-wallet:${{ env.DEPLOY_TAG }} aztecprotocol/cli-wallet:${{ github.sha }}

# docker push aztecprotocol/cli-wallet:${{ github.sha }}
build-cli-wallet:
needs: [set-network, build-aztec]
env:
BRANCH_NAME: ${{ needs.set-network.outputs.branch_name }}
DEPLOY_TAG: ${{ needs.set-network.outputs.deploy_tag }}
TF_VAR_DEPLOY_TAG: ${{ needs.set-network.outputs.deploy_tag }}
API_KEY: ${{ secrets[needs.set-network.outputs.network_api_key] }}
TF_VAR_API_KEY: ${{ secrets[needs.set-network.outputs.network_api_key] }}
API_KEY_NAME: ${{ needs.set-network.outputs.network_api_key }}
runs-on: ${{ github.actor }}-x86
steps:
- uses: actions/checkout@v4
with:
ref: "${{ env.GIT_COMMIT }}"
fetch-depth: 0
- uses: ./.github/ci-setup-action
with:
concurrency_key: build-cli-wallet-${{ github.actor }}
dockerhub_password: "${{ env.DOCKERHUB_PASSWORD }}"
- name: Check if only workflow flows have changed
id: check_only_workflow_changes
uses: actions/github-script@v7
with:
script: |
const { execSync } = require('child_process');
const changedFiles = execSync('git diff --name-only ${{ github.event.before }} ${{ github.sha }}')
.toString()
.split('\n')
.filter(line => line);
const prefixesToIgnore = ['.github', 'iac'];
const suffixesToIgnore = ['.tf'];
return changedFiles.every(file => (
prefixesToIgnore.some(prefix => file.startsWith(prefix)) ||
suffixesToIgnore.some(suffix => file.endsWith(suffix))
));
- name: "Build & Push aztec images"
timeout-minutes: 40
if: steps.check_only_workflow_changes.outputs.result == 'false'
run: |
env
earthly-ci --no-output --push ./yarn-project+export-cli-wallet --DIST_TAG=${{ env.DEPLOY_TAG }}

build-end:
runs-on: ubuntu-latest
needs: [
needs:
[
build-aztec,
build-faucet,
#build-cli-wallet,
build-cli-wallet,
build-mainnet-fork,
build-aztec-nargo,
set-network,
Expand Down