feat: key validation request key type runtime check #8033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Closing in favor of #8099 |
benesjan
deleted the
08-16-feat_key_validation_request_key_type_runtime_check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing around keys in aztec-nr it's very easy to make a mistake and pass e.g. ivpk to a function instead of ovpk. This has recently happened in Nico's PR and it was quite a pain to debug. For this reason I added a check that verifies that either nsk_app or ovsk_app is requested.
When I was coding this it came to my mind that insted of having this runtime check we could use type system to have a compile time check. This would require creating a type for each of the key types we currently have. I think this is the way to go so I would probably not merge this and do the compile time check instead.