Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from noir #8125

Merged
merged 34 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
86bdad7
[1 changes] feat: Add `Expr::as_block` and `Expr::has_semicolon` (htt…
AztecBot Aug 22, 2024
2566d6f
chore: apply sync fixes
AztecBot Aug 22, 2024
62d30d0
[1 changes] feat: LSP completion now works better in the middle of id…
AztecBot Aug 23, 2024
c01b3de
chore: apply sync fixes
AztecBot Aug 23, 2024
2269815
feat: LSP completion now works better in the middle of idents (https:…
AztecBot Aug 23, 2024
ba6b042
[1 changes] chore: Add docs for each comptime method (https://github.…
AztecBot Aug 24, 2024
e52297d
chore: apply sync fixes
AztecBot Aug 24, 2024
331e938
chore: Add docs for each comptime method (https://github.com/noir-lan…
AztecBot Aug 24, 2024
7724aea
[1 changes] chore: Add docs for each comptime method (https://github.…
AztecBot Aug 25, 2024
e38b6fd
chore: apply sync fixes
AztecBot Aug 25, 2024
3887420
chore: Add docs for each comptime method (https://github.com/noir-lan…
AztecBot Aug 25, 2024
02de365
[1 changes] chore: Add docs for each comptime method (https://github.…
AztecBot Aug 26, 2024
47c9678
chore: apply sync fixes
AztecBot Aug 26, 2024
e7ffae5
chore: Add docs for each comptime method (https://github.com/noir-lan…
AztecBot Aug 26, 2024
45448a9
Merge branch 'master' into sync-noir
sirasistant Aug 26, 2024
ac17f16
fix transpiler
sirasistant Aug 26, 2024
38fd592
fmt verify_honk_proof
vezenovm Aug 26, 2024
422e09b
update bignum dep
vezenovm Aug 26, 2024
c40848b
add option to compile workspace sequentially
vezenovm Aug 26, 2024
7e2fa62
refactor: extract to fn
sirasistant Aug 27, 2024
8c033b4
[1 changes] chore: crypto blackbox tests (https://github.com/noir-lan…
AztecBot Aug 27, 2024
51e2b2a
chore: apply sync fixes
AztecBot Aug 27, 2024
c77a497
chore: crypto blackbox tests (https://github.com/noir-lang/noir/pull/…
AztecBot Aug 27, 2024
9a333a0
fix: keep parallel compilation with a larger stack
sirasistant Aug 27, 2024
fb2e927
Merge branches 'sync-noir' and 'sync-noir' of github.com:AztecProtoco…
sirasistant Aug 27, 2024
5c7db10
fix
sirasistant Aug 27, 2024
0f4101a
fix: resolving brillig locations
sirasistant Aug 27, 2024
c64a9b2
Merge branch 'master' into sync-noir
sirasistant Aug 27, 2024
33d0674
fix: more stack for test_cmd and restore missing Nargo.toml
sirasistant Aug 27, 2024
56b9390
fmt
sirasistant Aug 27, 2024
b13e799
fix: verify honk prover.toml
sirasistant Aug 27, 2024
eefe726
restore nargo.toml
sirasistant Aug 27, 2024
a11d734
fix nargo test stack usage
sirasistant Aug 27, 2024
46a51ae
Merge branch 'master' into sync-noir
sirasistant Aug 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .noir-sync-commit
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1958a7932642e2fa556a903a3186b142a70e3e48
86c151aa43ba990a0e900995064a88fc2ae6637d
19 changes: 5 additions & 14 deletions avm-transpiler/src/transpile.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@ use std::collections::BTreeMap;

use acvm::acir::brillig::{BitSize, IntegerBitSize, Opcode as BrilligOpcode};

use acvm::acir::circuit::OpcodeLocation;
use acvm::acir::circuit::BrilligOpcodeLocation;
use acvm::brillig_vm::brillig::{
BinaryFieldOp, BinaryIntOp, BlackBoxOp, HeapArray, HeapVector, MemoryAddress, ValueOrArray,
};
use acvm::{AcirField, FieldElement};
use noirc_errors::debug_info::DebugInfo;
use noirc_errors::Location;

use crate::instructions::{
AvmInstruction, AvmOperand, AvmTypeTag, ALL_DIRECT, FIRST_OPERAND_INDIRECT,
Expand Down Expand Up @@ -1088,19 +1087,11 @@ pub fn patch_debug_info_pcs(
patched_debug_info.brillig_locations.iter()
{
// create a new map with all of its keys (OpcodeLocations) patched
let mut patched_locations: BTreeMap<OpcodeLocation, Vec<Location>> = BTreeMap::new();
let mut patched_locations = BTreeMap::new();
for (original_opcode_location, source_locations) in opcode_locations_map.iter() {
match original_opcode_location {
OpcodeLocation::Brillig { acir_index, brillig_index } => {
let avm_opcode_location = OpcodeLocation::Brillig {
acir_index: *acir_index,
// patch the PC
brillig_index: brillig_pcs_to_avm_pcs[*brillig_index],
};
patched_locations.insert(avm_opcode_location, source_locations.clone());
}
OpcodeLocation::Acir(_) => (),
}
let avm_opcode_location =
BrilligOpcodeLocation(brillig_pcs_to_avm_pcs[original_opcode_location.0]);
patched_locations.insert(avm_opcode_location, source_locations.clone());
}
// insert the new map as a brillig locations map for the current function id
patched_brillig_locations.insert(*brillig_function_id, patched_locations);
Expand Down
4 changes: 2 additions & 2 deletions noir-projects/noir-protocol-circuits/bootstrap.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ MIN_PARALLEL_VK_GENERATION_MEMORY=500000000
if [[ AVAILABLE_MEMORY -lt MIN_PARALLEL_VK_GENERATION_MEMORY ]]; then
echo "System does not have enough memory for parallel vk generation, falling back to sequential"

for pathname in "./target"/*.json; do
for pathname in "./target"/*.json; do
BB_HASH=$BB_HASH node ../scripts/generate_vk_json.js "$pathname" "./target/keys"
done

else

echo "Generating vks in parallel..."
for pathname in "./target"/*.json; do
for pathname in "./target"/*.json; do
BB_HASH=$BB_HASH node ../scripts/generate_vk_json.js "$pathname" "./target/keys" &
done

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ authors = [""]
compiler_version = ">=0.30.0"

[dependencies]
bigint = {tag = "v0.3.0", git = "https://github.com/noir-lang/noir-bignum" }
bigint = {tag = "v0.3.1", git = "https://github.com/noir-lang/noir-bignum" }
Loading
Loading