refactor: optimise l1 to l2 message fetching #8672
Merged
+66
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @LHerskind and the rest of your teammates on |
spypsy
approved these changes
Sep 20, 2024
just-mitch
approved these changes
Sep 20, 2024
Maddiaa0
approved these changes
Sep 20, 2024
LHerskind
force-pushed
the
lh/8620-handle-prune
branch
from
76c87ac
to
a2820bf
Compare
LHerskind
force-pushed
the
lh/inbox-sync-optimisation
branch
from
f14ff0f
to
49ad2a0
Compare
LHerskind
force-pushed
the
lh/8620-handle-prune
branch
from
a2820bf
to
ccaa1be
Compare
LHerskind
force-pushed
the
lh/inbox-sync-optimisation
branch
from
49ad2a0
to
c74f7de
Compare
LHerskind
force-pushed
the
lh/8620-handle-prune
branch
from
ccaa1be
to
46715c6
Compare
LHerskind
force-pushed
the
lh/inbox-sync-optimisation
branch
from
c74f7de
to
97e9b65
Compare
LHerskind
force-pushed
the
lh/8620-handle-prune
branch
from
46715c6
to
c79a869
Compare
LHerskind
force-pushed
the
lh/inbox-sync-optimisation
branch
from
97e9b65
to
b2ebb7f
Compare
LHerskind
force-pushed
the
lh/8620-handle-prune
branch
2 times, most recently
from
f591972
to
adf1a0b
Compare
LHerskind
force-pushed
the
lh/inbox-sync-optimisation
branch
from
b2ebb7f
to
bc9bc03
Compare
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Takes the same approach as done in other optimisations tasks related to #8457 and before it go looking at the events, it will check values in the contract to figure out if there is even anything to look for. If we figure that there is nothing to look for, we update the l1 block number of interest, and call it a day. This allow getting rid of a bunch of get logs call and replacing them with a single function call instead. Does not impact the tests in E2E significantly because they are running on anvil without anything but our rollup happening so there is not a lot of wasted effort there, but should see meaningful changes when pointed at larger systems.
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Takes the same approach as done in other optimisations tasks related to #8457 and before it go looking at the events, it will check values in the contract to figure out if there is even anything to look for. If we figure that there is nothing to look for, we update the l1 block number of interest, and call it a day. This allow getting rid of a bunch of get logs call and replacing them with a single function call instead. Does not impact the tests in E2E significantly because they are running on anvil without anything but our rollup happening so there is not a lot of wasted effort there, but should see meaningful changes when pointed at larger systems.
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Takes the same approach as done in other optimisations tasks related to #8457 and before it go looking at the events, it will check values in the contract to figure out if there is even anything to look for. If we figure that there is nothing to look for, we update the l1 block number of interest, and call it a day. This allow getting rid of a bunch of get logs call and replacing them with a single function call instead. Does not impact the tests in E2E significantly because they are running on anvil without anything but our rollup happening so there is not a lot of wasted effort there, but should see meaningful changes when pointed at larger systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes the same approach as done in other optimisations tasks related to #8457 and before it go looking at the events, it will check values in the contract to figure out if there is even anything to look for. If we figure that there is nothing to look for, we update the l1 block number of interest, and call it a day. This allow getting rid of a bunch of get logs call and replacing them with a single function call instead. Does not impact the tests in E2E significantly because they are running on anvil without anything but our rollup happening so there is not a lot of wasted effort there, but should see meaningful changes when pointed at larger systems.