Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bb.js acir tests #8862

Merged
merged 3 commits into from
Sep 27, 2024
Merged

fix: bb.js acir tests #8862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4afccf8
Update Earthfile
ludamad Sep 27, 2024
3be4768
Update Earthfile
ludamad Sep 27, 2024
7b4d3c5
Update ci.yml
ludamad Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ jobs:
- uses: actions/checkout@v4
with: { ref: "${{ env.GIT_COMMIT }}" }
- uses: ./.github/ci-setup-action
if: (needs.changes.outputs.non-docs == 'true' && needs.changes.outputs.non-misc-ci == 'true' && needs.changes.outputs.non-barretenberg-cpp == 'true') || github.ref_name == 'master'
with:
concurrency_key: build-x86
# prepare images locally, tagged by commit hash
Expand Down
4 changes: 2 additions & 2 deletions barretenberg/cpp/Earthfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ preset-sol:

preset-wasm-threads:
FROM +source
DO +CACHE_BUILD_BIN --prefix=preset-wasm-threads \
--command="cmake --preset wasm-threads -Bbuild && cmake --build build --target barretenberg.wasm && /opt/wasi-sdk/bin/llvm-strip ./build/bin/barretenberg.wasm"
DO +CACHE_BUILD_BIN --prefix=preset-wasm-threads-v1 \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently we need to add a prefix addendum if not changing the rebuild contents. Note once we do change the contents we can remove this

--command="cmake --preset wasm-threads -Bbuild && cmake --build build --target barretenberg.wasm"
SAVE ARTIFACT build/bin

preset-gcc:
Expand Down
Loading