Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add persistent storage for aztec nodes in the spartan cluster #8923

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

stevenplatt
Copy link
Collaborator

This PR includes two changes:

  • Adds persistent storage for Aztec nodes running the Spartan cluster
  • Repairs previously merged load balancer configurations

Persistent Storage

Nodes that were previously configured with mounted volumes are now configured to use volumeClaimTemplates. Rather than directly configuring a PersistentVolumeClaim, a volumeClaimTemplate will automatically append index suffixes when replicas increase, so that there is not a storage conflict.

Persistent Storage for Grafana

The currently bundles Grafana instance uses a standard PersistentVolumeClaim since it is not expected to be deployed with replicas. Grafana also has an OS-level user defined it its container, which assumes ownership of the volume once it is mounted. To allow remounting, the user have to be defined in the helm chart. This is done using a securityContext in Grafana yaml template.

Repaired Load Balancer Config

PR #8786 previously made network interfaces either internal or external. This meant that when the network was set as public, certain references to internal network interfaces were no longer reachable. Specifically items that address a node port (bootNodeURL for example).

This PR adds the load balancer as a second interface, without modifying the original.

Testing

Code in this PR has been tested by by deployed the updated helm configurations to the Spartan cluster using command:

helm upgrade --install staging . -n staging --set network.public=true

As part of this change, replica counts have also validated to work without causing conflict for volume mounts, network interfaces or other resources.

@stevenplatt stevenplatt enabled auto-merge (squash) October 1, 2024 22:19
@stevenplatt stevenplatt merged commit 23786be into master Oct 2, 2024
48 checks passed
@stevenplatt stevenplatt deleted the srp/aztec-node-persistent-disks branch October 2, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants