fix: non state update from pub processor #9634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
MirandaWood
changed the title
PhilWindle
approved these changes
Nov 4, 2024
dbanks12
approved these changes
Nov 4, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
PhilWindle
approved these changes
Nov 5, 2024
Maddiaa0
pushed a commit
that referenced
this pull request
Nov 6, 2024
Minimal repro of issue in public processor, in which state is not updated during simulation, so each tx comes out with the same `.startState`. This hasn't been caught because all of our testing either does: - One tx per block with public calls, so the initial db state is correct - Passes the *same db* to the public processor and the txHandler (see `TestContext`), so when the handler runs processedTxHandler.addNewTx(processedTx) it actually updates the db of both itself and the public processor EDIT: Note that failure is visible in `prover-client` CI tests [here](https://github.com/AztecProtocol/aztec-packages/actions/runs/11618042996/job/32356873092#step:5:788) --- Fix now included in this PR: - Update `this.db` for each processed tx in `public_processor` (this is eventually queried in `public_kernel_tail_simulator.ts` to get the state reference to use for the kernel tail) - Ensure that if a `txHandler` is supplied, its db is independent of the public processor's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal repro of issue in public processor, in which state is not updated during simulation, so each tx comes out with the same
.startState. This hasn't been caught because all of our testing either does:TestContext), so when the handler runs processedTxHandler.addNewTx(processedTx) it actually updates the db of both itself and the public processorEDIT: Note that failure is visible in
prover-clientCI tests hereFix now included in this PR:
this.dbfor each processed tx inpublic_processor(this is eventually queried inpublic_kernel_tail_simulator.tsto get the state reference to use for the kernel tail)txHandleris supplied, its db is independent of the public processor's