chore: switch to installing published binaries of foundry #9704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Biggest question is if this works in ARM, I created a version of this with the PR title -arm-build |
ludamad
added a commit
that referenced
this pull request
Nov 5, 2024
This redoes #9704 with the PR title pattern needed for an ARM build --------- Co-authored-by: Tom French <tom@tomfren.ch>
AztecBot
pushed a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Nov 6, 2024
This redoes AztecProtocol/aztec-packages#9704 with the PR title pattern needed for an ARM build --------- Co-authored-by: Tom French <tom@tomfren.ch>
Maddiaa0
pushed a commit
that referenced
this pull request
Nov 6, 2024
This redoes #9704 with the PR title pattern needed for an ARM build --------- Co-authored-by: Tom French <tom@tomfren.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nightly version of foundry we're using appears to publish arm64 binaries so it seems like it shouldn't be necessary to build from source anymore. I've updated any
foundryupcalls to pull this nightly release.