Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): configurable collection time #9741

Merged
merged 22 commits into from
Nov 7, 2024

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Nov 5, 2024

Makes metrics collection time configurable, + reduce collection time in e2e tests with metrics collection enabled

Copy link
Member Author

Maddiaa0 commented Nov 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Maddiaa0 and the rest of your teammates on Graphite Graphite

@Maddiaa0 Maddiaa0 force-pushed the md/configure-network-scraping-time branch from 6054b54 to a74f1e1 Compare November 5, 2024 06:36
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Base automatically changed from md/gossip-sub-metrics to master November 7, 2024 18:04
@Maddiaa0 Maddiaa0 enabled auto-merge (squash) November 7, 2024 18:18
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Changes to circuit sizes

Generated at commit: 5adc88245171a4dac2abf4be7fbaf2ea44c8c0a2, compared to commit: 1b41d3855badb318e7a37bd9e4f18d62af626184

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init +190 ❌ +0.88% +3,837 ❌ +12.34%
private_kernel_inner +189 ❌ +0.50% +3,836 ❌ +7.14%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init 21,748 (+190) +0.88% 34,933 (+3,837) +12.34%
private_kernel_inner 38,127 (+189) +0.50% 57,586 (+3,836) +7.14%

@Maddiaa0 Maddiaa0 merged commit 48969ce into master Nov 7, 2024
68 checks passed
@Maddiaa0 Maddiaa0 deleted the md/configure-network-scraping-time branch November 7, 2024 18:54
ludamad pushed a commit that referenced this pull request Nov 7, 2024
Makes metrics collection time configurable, + reduce collection time in
e2e tests with metrics collection enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants