feat: IPA Accumulator in Builder #9846

lucasxia01 · 2024-11-08T16:01:29Z

Adds IPA claim to builder, pk, vk, so that the verifier knows where to look to extract the IPA claim from. Modifies the UltraRecursiveVerifier to extract out the IPA claim from the public inputs and return it.

Also modifies native verifier to check the IPA claim and proof.

…builder

barretenberg/cpp/src/barretenberg/commitment_schemes/claim.hpp

lucasxia01 · 2024-11-15T23:36:32Z

barretenberg/cpp/src/barretenberg/commitment_schemes/ipa/ipa.hpp

@@ -749,20 +749,21 @@ template <typename Curve_> class IPA {
    }

    /**
-     * @brief Takes two IPA claims and accumulates them into 1 IPA claim.
-     * @details We create an IPA accumulator by running the IPA recursive verifier on each claim. Then, we generate challenges, and use these challenges to compute the new accumulator. We also create the accumulated polynomial. 
+     * @brief Takes two IPA claims and accumulates them into 1 IPA claim. Also computes IPA proof for the claim.


modified so that accumulate just returns the IPA proof directly

lucasxia01 · 2024-11-15T23:39:07Z

barretenberg/cpp/src/barretenberg/examples/join_split/join_split.test.cpp

@@ -33,8 +33,8 @@ using namespace bb::join_split_example::proofs::notes::native;
 using key_pair = join_split_example::fixtures::grumpkin_key_pair;

 auto create_account_leaf_data(fr const& account_alias_hash,
-                              grumpkin::g1::affine_element const& owner_key,
-                              grumpkin::g1::affine_element const& signing_key)
+                              bb::grumpkin::g1::affine_element const& owner_key,


had to add namespace stuff to avoid ambiguous errors...

Hm, surprised by that.

lucasxia01 · 2024-11-15T23:40:12Z

barretenberg/cpp/src/barretenberg/flavor/flavor.hpp

@@ -379,6 +379,9 @@ MegaZKRecursiveFlavor_<UltraCircuitBuilder>>;
 template <typename T>
 concept HasDataBus = IsMegaFlavor<T>;

+template <typename T>
+concept DoesRecursiveIPA = IsAnyOf<T, UltraFlavor, UltraFlavorWithZK>;


not ultra keccak because that will only be called on the root rollup circuit which will just verify the IPA claim.

What is a more precise description of this concept? Is it for flavors that do aggregation OR verification (and possibly both)?

its a flavor that will attach an IPA proof and claim to its proof.

lucasxia01 · 2024-11-15T23:40:42Z

...nberg/cpp/src/barretenberg/stdlib/client_ivc_verifier/client_ivc_recursive_verifier.test.cpp

    tube_builder->add_pairing_point_accumulator(
        stdlib::recursion::init_default_agg_obj_indices<Builder>(*tube_builder));
+    // The tube only calls an IPA recursive verifier once, so we can just add this IPA claim and proof


for the tube circuit, add the IPA claim

lucasxia01 · 2024-11-15T23:41:09Z

barretenberg/cpp/src/barretenberg/stdlib/encryption/schnorr/schnorr.test.cpp

-using byte_array_ct = byte_array<Builder>;
-using field_ct = field_t<Builder>;
-using witness_ct = witness_t<Builder>;
+using bool_ct = stdlib::bool_t<Builder>;


namespace changes for some reason.. maybe because of extra includes

barretenberg/cpp/src/barretenberg/stdlib/goblin_verifier/goblin_recursive_verifier.test.cpp

lucasxia01 · 2024-11-15T23:43:03Z

barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/circuit_builder_base.hpp

    bool contains_pairing_point_accumulator = false;

+    // Public input indices which contain the output IPA opening claim


adding the IPA claim public inputs to the builder

…/aztec-packages into lx/ipa-accumulator-builder

lucasxia01 · 2024-11-18T18:22:25Z

barretenberg/cpp/src/barretenberg/ultra_honk/ultra_verifier.cpp

@@ -22,6 +23,45 @@ template <typename Flavor> bool UltraVerifier_<Flavor>::verify_proof(const HonkP
            transcript->template get_challenge<FF>("Sumcheck:gate_challenge_" + std::to_string(idx)));
    }

+    const auto recover_fq_from_public_inputs = [](std::array<FF, 4> limbs) {


parses out the IPA claim from the public inputs using the vkey and runs the. native verifier

lucasxia01 · 2024-11-18T18:22:50Z

barretenberg/cpp/src/barretenberg/ultra_honk/ultra_verifier.cpp

+            };
+
+            // verify the ipa_proof with this claim
+            auto crs_factory = std::make_shared<srs::factories::FileCrsFactory<curve::Grumpkin>>(


not sure what I can do about this CRS stuff here

codygunton

Good work, just asking you to strengthen it a bit

barretenberg/cpp/src/barretenberg/bb/main.cpp

codygunton · 2024-11-18T21:04:29Z

barretenberg/cpp/src/barretenberg/transcript/transcript.hpp

@@ -450,6 +450,15 @@ static bb::StdlibProof<Builder> convert_proof_to_witness(Builder* builder, const
    return result;
 }

+template <typename Builder> static bb::HonkProof convert_stdlib_proof_to_native(const StdlibProof<Builder>& proof)


By default we should use constructors to represent the construction of objects. Here is a pattern we can use to do that in this case: https://godbolt.org/z/MrcGooh69.

didn't follow a constructor pattern here because both HonkProof and StdlibProof are just vectors and not actually classes that we define. Could be reaching the point where we create classes for them

codygunton · 2024-11-18T21:13:02Z

barretenberg/cpp/src/barretenberg/commitment_schemes/ipa/ipa.hpp

+                                                     bb::fq(output_claim.opening_pair.evaluation.get_value()) };
+        Polynomial<fq> challenge_poly = create_challenge_poly(uint32_t(pair_1.log_poly_length.get_value()), native_u_challenges_inv_1, uint32_t(pair_2.log_poly_length.get_value()), native_u_challenges_inv_2, fq(alpha.get_value()));
+
+        ASSERT(challenge_poly.evaluate(opening_pair.challenge) == opening_pair.evaluation && "Opening claim does not hold for challenge polynomial.");


Just checked that the string evaluates to true... nice trick.

codygunton · 2024-11-18T21:14:26Z

barretenberg/cpp/src/barretenberg/examples/join_split/join_split.test.cpp

@@ -33,8 +33,8 @@ using namespace bb::join_split_example::proofs::notes::native;
 using key_pair = join_split_example::fixtures::grumpkin_key_pair;

 auto create_account_leaf_data(fr const& account_alias_hash,
-                              grumpkin::g1::affine_element const& owner_key,
-                              grumpkin::g1::affine_element const& signing_key)
+                              bb::grumpkin::g1::affine_element const& owner_key,


Hm, surprised by that.

codygunton · 2024-11-18T21:16:00Z

barretenberg/cpp/src/barretenberg/flavor/flavor.hpp

@@ -379,6 +379,9 @@ MegaZKRecursiveFlavor_<UltraCircuitBuilder>>;
 template <typename T>
 concept HasDataBus = IsMegaFlavor<T>;

+template <typename T>
+concept DoesRecursiveIPA = IsAnyOf<T, UltraFlavor, UltraFlavorWithZK>;


What is a more precise description of this concept? Is it for flavors that do aggregation OR verification (and possibly both)?

codygunton · 2024-11-18T21:16:49Z

barretenberg/cpp/src/barretenberg/plonk_honk_shared/types/aggregation_object_type.hpp

+// of the nested aggregation object.
+using PairingPointAccumulatorPubInputIndices = std::array<uint32_t, PAIRING_POINT_ACCUMULATOR_SIZE>;
+
+constexpr uint32_t IPA_CLAIM_SIZE = 6;


FYI IIUC static constexpr will ensure that this is initialized at compilation time.

shouldn't constexpr also initialize it at compilation time?

Yes but I mean static constexpr

codygunton · 2024-11-18T21:20:47Z

barretenberg/cpp/src/barretenberg/stdlib/eccvm_verifier/eccvm_recursive_verifier.cpp

-    const typename PCS::VerifierAccumulator batched_opening_accumulator =
-        PCS::reduce_verify(batch_opening_claim, ipa_transcript);
+    // // TODO(https://github.com/AztecProtocol/barretenberg/issues/1142): Handle this return value correctly.
+    // const typename PCS::VerifierAccumulator batched_opening_accumulator =


TODO resolved?

yep, we no longer call the IPA recursive verifier in the eccvm recursive verifier

codygunton · 2024-11-18T21:21:33Z

barretenberg/cpp/src/barretenberg/stdlib/goblin_verifier/goblin_recursive_verifier.test.cpp

@@ -113,7 +113,7 @@ TEST_F(GoblinRecursiveVerifierTests, ECCVMFailure)

    // Tamper with the ECCVM proof
    for (auto& val : proof.eccvm_proof.pre_ipa_proof) {
-        if (val > 0) { // tamper by finding the tenth non-zero value and incrementing it by 1
+        if (val > 0) { // tamper by finding the first non-zero value and incrementing it by 1


barretenberg/cpp/src/barretenberg/ultra_honk/ultra_verifier.cpp

codygunton · 2024-11-18T21:26:40Z

barretenberg/cpp/src/barretenberg/ultra_honk/ultra_verifier.cpp

+            auto ipa_transcript = std::make_shared<Transcript>(ipa_proof);
+            bool ipa_result =
+                IPA<curve::Grumpkin>::reduce_verify(grumpkin_verifier_commitment_key, ipa_claim, ipa_transcript);
+            if (!ipa_result) {


Does this not return in the ipa_result case? Seems like it shouldn't compile...

well, it continues on to the decider verifier. The function will always return

…builder

* master: (67 commits) chore: Fix bad merge on AztecLMDBStore initializer feat: add persisted database of proving jobs (#9942) chore: Clean up data configuration (#9973) chore: remove public kernels (#10027) chore: misc cleanup, docs and renaming (#9968) feat: IPA Accumulator in Builder (#9846) chore(docs): Updates to token contract (#9954) test(avm): minor benchmarking (#9869) chore(ci): run `l1-contracts` CI in parallel with `build` step (#10024) chore: build acir test programs in parallel to e2e build step (#9988) chore: pull out `array_set` pass changes (#9993) feat(avm): ephemeral avm tree (#9798) fix: don't take down runners with faulty runner check (#10019) feat(docs): add transaction profiler docs (#9932) chore: hotfix runner wait (#10018) refactor: remove EnqueuedCallSimulator (#10015) refactor: stop calling public kernels (#9971) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits ...

This reverts commit 8e74cd0.

Reverts #9846 due to a failure in the prover-full test

Reverts AztecProtocol/aztec-packages#9846 due to a failure in the prover-full test

initial builder object

4b2f1cd

lucasxia01 self-assigned this Nov 8, 2024

lucasxia01 added 7 commits November 12, 2024 19:00

rename

3a6bdad

return unfinished transcript

ed12d5b

ipa claim indices

b948683

add ipa claim to public inputs upon accumulation

beb03a4

Merge remote-tracking branch 'origin/master' into lx/ipa-accumulator-…

39b0b76

…builder

fix build

20a6933

adding ipa claim to proving/verification keys

b3ebdeb

lucasxia01 marked this pull request as ready for review November 14, 2024 00:53

lucasxia01 added 8 commits November 14, 2024 18:38

fix build

98e8018

Merge remote-tracking branch 'origin/master' into lx/ipa-accumulator-…

87163af

…builder

fix some random tests with namespace ambiguity issues

f1a429d

fix serialization

c86252b

fix test

cb40e08

modify eccvm verify_proof

68e8acb

make accumulate also generate the ipa proof

3c83148

add ipa claim/proof to tube

ee98551

lucasxia01 requested review from jeanmon, IlyasRidhuan and fcarreiro as code owners November 15, 2024 22:56

Merge remote-tracking branch 'origin/master' into lx/ipa-accumulator-…

113ba04

…builder

lucasxia01 commented Nov 15, 2024

View reviewed changes

barretenberg/cpp/src/barretenberg/commitment_schemes/claim.hpp Show resolved Hide resolved

lucasxia01 commented Nov 15, 2024

View reviewed changes

barretenberg/cpp/src/barretenberg/stdlib/goblin_verifier/goblin_recursive_verifier.test.cpp Outdated Show resolved Hide resolved

lucasxia01 commented Nov 15, 2024

View reviewed changes

lucasxia01 removed the e2e-all CI: Enables this CI job. label Nov 18, 2024

lucasxia01 added 2 commits November 18, 2024 17:12

Merge branch 'lx/ipa-accumulator-builder' of github.com:AztecProtocol…

1c7e792

…/aztec-packages into lx/ipa-accumulator-builder

add native verifier to client ivc recursive verifier test

d1cd1cd

codygunton self-requested a review November 18, 2024 18:20

lucasxia01 commented Nov 18, 2024

View reviewed changes

lucasxia01 added 2 commits November 18, 2024 18:44

update some tests

9d34263

update avm file

e260b87

lucasxia01 requested a review from Maddiaa0 as a code owner November 18, 2024 18:46

codygunton requested changes Nov 18, 2024

View reviewed changes

lucasxia01 added 4 commits November 18, 2024 21:53

Remove long client ivc rec verifier output name

dfc0b81

add TODO

ea3f929

rename concept

f8e9197

addressed comments

2adab61

codygunton approved these changes Nov 18, 2024

View reviewed changes

lucasxia01 added 5 commits November 19, 2024 00:06

forgotten comment

b96488c

Merge remote-tracking branch 'origin/master' into lx/ipa-accumulator-…

346eba8

…builder

try fixing verify_tube flow

0f35e51

fix tests

790fa11

fix acir tests hopefully

13de7ef

lucasxia01 enabled auto-merge (squash) November 19, 2024 04:25

lucasxia01 merged commit 8e74cd0 into master Nov 19, 2024
69 of 72 checks passed

lucasxia01 deleted the lx/ipa-accumulator-builder branch November 19, 2024 05:21

AztecBot mentioned this pull request Nov 19, 2024

chore(master): Release 0.63.0 #9651

Merged

lucasxia01 added a commit that referenced this pull request Nov 19, 2024

Revert "feat: IPA Accumulator in Builder (#9846)"

c7110c4

This reverts commit 8e74cd0.

lucasxia01 mentioned this pull request Nov 19, 2024

chore: Revert "feat: IPA Accumulator in Builder" #10036

Merged

lucasxia01 added a commit that referenced this pull request Nov 19, 2024

chore: Revert "feat: IPA Accumulator in Builder" (#10036)

9b10f7f

Reverts #9846 due to a failure in the prover-full test

lucasxia01 restored the lx/ipa-accumulator-builder branch November 19, 2024 18:25

AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this pull request Nov 20, 2024

chore: Revert "feat: IPA Accumulator in Builder" (#10036)

dfe6138

Reverts AztecProtocol/aztec-packages#9846 due to a failure in the prover-full test

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: IPA Accumulator in Builder #9846

feat: IPA Accumulator in Builder #9846

lucasxia01 commented Nov 8, 2024 •

edited

Loading

lucasxia01 Nov 15, 2024

lucasxia01 Nov 15, 2024

codygunton Nov 18, 2024

lucasxia01 Nov 15, 2024

codygunton Nov 18, 2024

lucasxia01 Nov 18, 2024

lucasxia01 Nov 15, 2024

lucasxia01 Nov 15, 2024

lucasxia01 Nov 15, 2024

lucasxia01 Nov 18, 2024

lucasxia01 Nov 18, 2024

codygunton left a comment

codygunton Nov 18, 2024 •

edited

Loading

lucasxia01 Nov 18, 2024

codygunton Nov 18, 2024

codygunton Nov 18, 2024

codygunton Nov 18, 2024

codygunton Nov 18, 2024

lucasxia01 Nov 18, 2024

codygunton Nov 18, 2024

codygunton Nov 18, 2024

lucasxia01 Nov 18, 2024

codygunton Nov 18, 2024

codygunton Nov 18, 2024

lucasxia01 Nov 18, 2024

		bool contains_pairing_point_accumulator = false;

		// Public input indices which contain the output IPA opening claim

feat: IPA Accumulator in Builder #9846

feat: IPA Accumulator in Builder #9846

Conversation

lucasxia01 commented Nov 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codygunton left a comment

Choose a reason for hiding this comment

codygunton Nov 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucasxia01 commented Nov 8, 2024 •

edited

Loading

codygunton Nov 18, 2024 •

edited

Loading