Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: serialization debug utility #126

Merged
merged 5 commits into from
Mar 29, 2023
Merged

Conversation

ludamad
Copy link
Contributor

@ludamad ludamad commented Mar 29, 2023

Description

Provides magic constants ('canaries') to check serialization alignment. Enabled with -DSERIALIZE_CANARY (or similar cmake option setting)
See AztecProtocol/barretenberg#290

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

Note
If you are updating the submodule, please make sure you do it in its own special PR and avoid making changes to the submodule as a part of other PRs.
To update a submodule, you can run the following commands:

$ git submodule update --recursive

Alternatively, you can select a particular commit in barretenberg/aztec3 that you wish to point to:

$ cd barretenberg
$ git pull origin aztec3        # This will point to the latest commit in `barretenberg/aztec3`
$ git checkout <commit_hash>    # Use this if you wish to point to a particular commit.
$ cd ..
$ git add . && git commit -m <commit_msg>
$ git push

@ludamad ludamad merged commit 0e8dba9 into master Mar 29, 2023
@ludamad ludamad deleted the feat/serialize-debug-utility branch March 29, 2023 13:23
dbanks12 pushed a commit that referenced this pull request Mar 29, 2023
* feat: serialize canary

* bump bb

* feat: pass along asan settings

* Revert "bump bb"

This reverts commit 514682d.

* feat: pass build type to cmake
dbanks12 pushed a commit that referenced this pull request Mar 29, 2023
* feat: serialize canary

* bump bb

* feat: pass along asan settings

* Revert "bump bb"

This reverts commit 514682d.

* feat: pass build type to cmake
Maddiaa0 pushed a commit that referenced this pull request Mar 29, 2023
* intial root

* feat: pass on snaphots

* fix: update naming for consistency + extend root rollup logic

* feat: serialization debug utility (#126)

* feat: serialize canary

* bump bb

* feat: pass along asan settings

* Revert "bump bb"

This reverts commit 514682d.

* feat: pass build type to cmake

* initial commit with root cbinds

* root rollup cbind working

* fix root test

---------

Co-authored-by: LHerskind <lasse.herskind@gmail.com>
Co-authored-by: ludamad <adam.domurad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant