Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gate_challenges for constant honk proof size #1041

Closed
ledwards2225 opened this issue Jun 28, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#7494
Closed

Comments

@ledwards2225
Copy link
Collaborator

Currently we generate log_n many gate challenges (the challenges used to construct the pow polynomial for sumcheck). For consistency with the constant honk proof size work, this would need to be updated in accordance with CONST_PROOF_SIZE_LOG_N. This dependence on the log of the circuit size does not currently effect the constant proof size / constant recursive verifier circuit work since at the time of writing this constraints are not generated for hashing in the the Ultra recursive verifier. Until hashing produces constraints, it is difficult to test any updates to this code.

maramihali added a commit to AztecProtocol/aztec-packages that referenced this issue Aug 21, 2024
Add Poseidon2 gates to the `UltraCircuitBuilder` which now ensures that
recursive verifier instantiated with the Ultra arithmetisation produce
the correct number of constraints.

Updates required:
* change verification key length and constant proof length constants
across the codebase (two selectors from the new gate whose commitments
need to be in the vk and the poseidon relation becomes the one with the
highest degree); changes to Prover.toml accordingly
* ensure the ultra recursive verifier still stays constant size now that
hashing produces gates
* small modification to solidity verifer to reflect the ones in cpp with
the caveat that the UltraKeccak flavor still doesnt support Poseidon
gate (changes coming in a followup PR)

Tube circuit changes in # of gates (post finalisation):
- number of gates prior this change, in master: 13947018
- number of gates post this change: 14038982

Closes AztecProtocol/barretenberg#1041
AztecBot pushed a commit that referenced this issue Aug 22, 2024
Add Poseidon2 gates to the `UltraCircuitBuilder` which now ensures that
recursive verifier instantiated with the Ultra arithmetisation produce
the correct number of constraints.

Updates required:
* change verification key length and constant proof length constants
across the codebase (two selectors from the new gate whose commitments
need to be in the vk and the poseidon relation becomes the one with the
highest degree); changes to Prover.toml accordingly
* ensure the ultra recursive verifier still stays constant size now that
hashing produces gates
* small modification to solidity verifer to reflect the ones in cpp with
the caveat that the UltraKeccak flavor still doesnt support Poseidon
gate (changes coming in a followup PR)

Tube circuit changes in # of gates (post finalisation):
- number of gates prior this change, in master: 13947018
- number of gates post this change: 14038982

Closes #1041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant