Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add implication of not having simulating simulations #423

Closed
Tracked by #220
critesjosh opened this issue Oct 11, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#9438
Closed
Tracked by #220

[docs] Add implication of not having simulating simulations #423

critesjosh opened this issue Oct 11, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#9438
Assignees
@critesjosh
Labels
Aztec Docs
Milestone
Testnet

Comments

@critesjosh
Copy link
Collaborator

Let's do a doc on how this may break some contracts (especially with no authwits) and its other poor uX/Devex repercussions. e.g. reading functions that change state can cause state changes in the simulator, like in this example contract, where reading teh hotp code causes it to increment

AztecProtocol/aztec-packages#9133
@critesjosh critesjosh mentioned this issue Oct 11, 2024
Open
@critesjosh critesjosh added this to the Testnet milestone Oct 25, 2024
@critesjosh critesjosh self-assigned this Oct 28, 2024
@critesjosh critesjosh mentioned this issue Oct 30, 2024
Merged
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Nov 6, 2024
@critesjosh @AztecBot
chore(docs): authwit note, not simulating simulations (#9438)
2495bdb 
Adds notes to the docs that indicate that authwits only work in single
player mode, describes the problems with not simulating simulations, and
updates the bberg readme install instructions

closes AztecProtocol/dev-rel#422
closes AztecProtocol/dev-rel#433
closes AztecProtocol/aztec-packages#9256
closes AztecProtocol/dev-rel#423
closes AztecProtocol/aztec-packages#6865
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this issue Nov 6, 2024
@critesjosh @AztecBot
chore(docs): authwit note, not simulating simulations (#9438)
6909bfd 
Adds notes to the docs that indicate that authwits only work in single
player mode, describes the problems with not simulating simulations, and
updates the bberg readme install instructions

closes AztecProtocol/dev-rel#422
closes AztecProtocol/dev-rel#433
closes AztecProtocol/aztec-packages#9256
closes AztecProtocol/dev-rel#423
closes AztecProtocol/aztec-packages#6865
Maddiaa0 pushed a commit to AztecProtocol/aztec-packages that referenced this issue Nov 6, 2024
@critesjosh @Maddiaa0
chore(docs): authwit note, not simulating simulations (#9438)
e677782 
Adds notes to the docs that indicate that authwits only work in single
player mode, describes the problems with not simulating simulations, and
updates the bberg readme install instructions

closes AztecProtocol/dev-rel#422
closes AztecProtocol/dev-rel#433
closes #9256
closes AztecProtocol/dev-rel#423
closes #6865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@critesjosh critesjosh

Labels
Aztec Docs
Projects
None yet
Milestone
Testnet
Development

Successfully merging a pull request may close this issue.

chore(docs): authwit note, not simulating simulations AztecProtocol/aztec-packages
1 participant
@critesjosh