Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Commit

Permalink
chore(compiler): Remove wasm option from noir compiler (#1628)
Browse files Browse the repository at this point in the history
Issue AztecProtocol/aztec-packages#1597 was
preventing users from installing the Aztec CLI via npm.

Releasing a new version of `noir_wasm` and `noir-source-resolver` didn't
fix the issue unfortunately, and further tweaking `noir-source-resolver`
so it's loaded properly leads to errors due since [the resolver is a
global
object](https://nodejs.org/api/packages.html#approach-2-isolate-state)
but it's treated as different objects when loaded as commonjs or esm. So
the noir-compiler here is properly configuring the resolver in esm-land,
but noir_wasm loads it via commonjs and fails. To make things worse,
jest seems to be complaining about misconfigured esm modules here.

Given that noir_wasm is not kept up-to-date atm and is not the
recommended way to compile noir contracts, I decided to time out and
remove it altogether for now. I'm creating a new issue to revisit this
in the future.

Fixes AztecProtocol/aztec-packages#1597
  • Loading branch information
spalladino authored and AztecBot committed Aug 18, 2023
1 parent 9423d69 commit b820d3b
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion docs/dev_docs/contracts/compiling.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ npm install @aztec/noir-compiler

The compiler exposes the following functions:
- `compileUsingNargo`: Compiles a Noir project in the target folder using the `nargo` binary available on the shell `PATH` and returns the generated ABIs.
- `compileUsingNoirWasm`: Compiles a Noir project in the target folder using an embedded noir-wasm package and returns the generated ABIs.
- `generateTypescriptContractInterface`: Generates a typescript class for the given contract ABI.
- `generateNoirContractInterface`: Generates a Noir interface struct for the given contract ABI.

Expand Down

0 comments on commit b820d3b

Please sign in to comment.