Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BBerg code generated: new interface to pass a trace to circuit_builder #21

Merged
merged 4 commits into from
Nov 23, 2023
Merged

BBerg code generated: new interface to pass a trace to circuit_builder #21

merged 4 commits into from
Nov 23, 2023

Conversation

jeanmon
Copy link
Collaborator

@jeanmon jeanmon commented Nov 23, 2023 •
edited
Loading

We rename cpp code generated as follows: XXX_trace.hpp by XXXcircuit_builder.hpp

We change the routine build_circuit() by set_trace() in XXXcircuit_builder.hpp

Rust related source code was renamed accordingly with the new convention:

  • circuit_builder.rs ---> vm_builder.rs
  • trace_builder.rs ---> circuit_builder.rs

Maddiaa0
Maddiaa0 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we ball

@jeanmon jeanmon merged commit e8ba49b into avm Nov 23, 2023
1 of 2 checks passed
@jeanmon jeanmon deleted the jm/new-interface branch November 23, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maddiaa0 Maddiaa0 Maddiaa0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanmon @Maddiaa0