Support for large unsigned integer constants up to 256 bits #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maddiaa0
approved these changes
Dec 20, 2023
| @@ -328,7 +329,27 @@ fn craft_expression<T: FieldElement>( | |||
| collected_public_identities: &mut HashSet<String>, | |||
| ) -> BBIdentity { | |||
| match expr { | |||
| Expression::Number(n) => (1, format!("FF({})", n.to_arbitrary_integer())), | |||
| Expression::Number(n) => { | |||
There was a problem hiding this comment.
Could all of these be covered by the FF("hex string") constructor ?
There was a problem hiding this comment.
Good idea. According to the current cpp source code, this constructor takes only zero-padded/fixed size hex representation. This means that the cpp generated code would have very long string even for small constants which is not so nice I would say.
See relevant cpp source code:
https://github.com/AztecProtocol/aztec-packages/blob/f1eb6d5b6e3221e5a5b8f55632dba066d4cfbc24/barretenberg/cpp/src/barretenberg/numeric/uint256/uint256.hpp#L61
| } | ||
| if number.bits() < 256 { | ||
| let mut chunks: Vec<u64> = number.iter_u64_digits().collect::<Vec<u64>>(); | ||
| chunks.resize(4, 0); |
There was a problem hiding this comment.
Is the endianness of this concrete ?
There was a problem hiding this comment.
You meant "correct"? Yes I checked this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a literal unsigned integer larger than 32 bits is not supported.
We suffix unsigned integer literals below 64 bits with the "UL" suffix.
Integers with more than 64 bits and less than 256 is supported through a uint256_t constructor call.