Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Realm Service #7

Merged
merged 11 commits into from
Nov 6, 2018
Merged

New Realm Service #7

merged 11 commits into from
Nov 6, 2018

Conversation

Scuilion
Copy link
Contributor

Added read, update, and delete Realms.

@Azuka
Copy link
Owner

Azuka commented Oct 21, 2018

@Scuilion, I'm really sorry I did not get the notification for this. I'm reviewing now.

Azuka
Azuka previously requested changes Oct 22, 2018
View reviewed changes
Copy link
Owner

@Azuka Azuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Do you mind making the suggested changes and rebasing with latest master to get checks to run?

Readme.md Outdated Show resolved Hide resolved
keycloak/realm_service.go Outdated Show resolved Hide resolved
keycloak/realm_service.go Outdated Show resolved Hide resolved
keycloak/realms.go Outdated Show resolved Hide resolved
keycloak/utils.go Outdated Show resolved Hide resolved
@Scuilion
Copy link
Contributor Author

I believe the linting is failing because of this recent change to go.uuid
satori/go.uuid#18

@Azuka
Copy link
Owner

Azuka commented Oct 27, 2018

I'll take a look later today. Most of my repos using uuid have switched to https://github.com/gofrs/uuid

@Azuka Azuka mentioned this pull request Nov 2, 2018
Merged
@Azuka
Copy link
Owner

Azuka commented Nov 2, 2018 •
edited
Loading

@Scuilion, I'm sorry for the delay. Can you pull in the latest changes? After that I think we're good to go.

Edit: I removed uuid, so you'd want to match how you generate a random string unless you want something specialized..

@Scuilion
Copy link
Contributor Author

Scuilion commented Nov 6, 2018

Not sure why the dependency can't be resolved.

@Azuka Azuka dismissed their stale review November 6, 2018 04:25

Fixed.

@Azuka
Copy link
Owner

Azuka commented Nov 6, 2018 •
edited
Loading

@Scuilion, the issue seems to be with easyjson, especially when vendored. I'm removing it for now. Can you resolve the conflicts and I'll merge?

@Azuka
Copy link
Owner

Azuka commented Nov 6, 2018

Actually, I went ahead and fixed. Thanks for the work!

@Azuka Azuka merged commit d900747 into Azuka:master Nov 6, 2018
thspinto referenced this pull request in thspinto/keycloak-admin-go Apr 21, 2019
@Scuilion @thspinto
New Realm Service (#7)
ca533b8 
* add read, update, and delete Realms

* Update build and imports, request templates. (#8)

* Update issue templates

* add read, update, and delete Realms

* Update build and imports, request templates. (#8)

* add read, update, and delete Realms

* Remove uuid from tests.

* add read, update, and delete Realms

* add read, update, and delete Realms

* Fix build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azuka Azuka Azuka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Scuilion @Azuka