Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11 -- Split artist and title on first delimiter #12

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

MarkWasley
Copy link
Contributor

Split artist and title correctly when there are multiple delimiters. I have also added spaces around the delimiter to avoid splitting artists with hyphenated names in the wrong place.

Fixes issue:
#11

Split artist and title correctly when there are multiple delimiters.
@BusterNeece
Copy link
Member

@MarkWasley We shouldn't change the default argument for the delimiter on its own since it's used in the Shoutcast adapters as-is, without the spaces, due to some versions of Shoutcast sending artist/title combinations without the spaces. If you want to change the default parameter to what Icecast uses, that's fine but you should also change the Shoutcast adapters to explicitly specify the other delimiter format.

@MarkWasley
Copy link
Contributor Author

@BusterNeece I'm pleased you've seen this. How do we fix this issue then? I didn't want to add the spaces, but in testing I discovered the function couldn't differentiate between the delimiter and hyphenated names. Look forward to your thoughts.

@BusterNeece BusterNeece merged commit c19dad4 into AzuraCast:main Aug 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants