Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NSG to AzureBastionSubnet - Fixing #240 #266

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Add NSG to AzureBastionSubnet - Fixing #240 #266

merged 2 commits into from
Jun 20, 2022

Conversation

jtracey93
Copy link
Contributor

@jtracey93 jtracey93 commented Jun 17, 2022

Overview/Summary

This PR adds an NSG to the AzureBastionSubnet

This PR fixes/adds/changes/removes

  1. Fixes 💡 Feature Request - Add NSGs to AzureBastionSubnet #240 by adding NSG to AzureBastionSubnet

Breaking Changes

None

Testing Evidence

Tested in my own environment and deployed successfully.

PR Tests will confirm also

As part of this Pull Request I have

@jtracey93 jtracey93 requested a review from jfaurskov June 17, 2022 18:13
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Jun 17, 2022
@jtracey93
Copy link
Contributor Author

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 removed the Needs: Triage 🔍 Needs triaging by the team label Jun 17, 2022
@jtracey93
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Contributor Author

Markdown link check failure is a false positive.

Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 90b7027 into Azure:main Jun 20, 2022
@jtracey93 jtracey93 deleted the fix-240 branch June 20, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Feature Request - Add NSGs to AzureBastionSubnet
2 participants