Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize Route Table Entry Names #777

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

alisakina99
Copy link
Contributor

@alisakina99 alisakina99 commented Apr 30, 2024

Overview/Summary

Editing the main bicep module file (1), parameters files (5), and generated docs file (1) to parameterize route entry name(s) in the route table (VWAN hub to Az Firewall).

AB#34507
Closes #709

This PR fixes/adds/changes/removes

  1. adds paramater initialization to main infra-as-code/bicep/modules/vwanConnectivity/vwanConnectivity.bicep and references it during route table resource creation
  2. adds parameter to infra-as-code/bicep/modules/vwanConnectivity/parameters/mc-vwanConnectivity.parameters.all.json
  3. adds parameter to infra-as-code/bicep/modules/vwanConnectivity/parameters/mc-vwanConnectivity.parameters.min.json
  4. adds parameter to infra-as-code/bicep/modules/vwanConnectivity/parameters/vwanConnectivity.parameters.all.json
  5. adds parameter to infra-as-code/bicep/modules/vwanConnectivity/parameters/vwanConnectivity.parameters.az.all.json
  6. adds parameter to infra-as-code/bicep/modules/vwanConnectivity/parameters/vwanConnectivity.parameters.min.json
  7. adds entry to markdown file that documents parameters: infra-as-code/bicep/modules/vwanConnectivity/generateddocs/vwanConnectivity.bicep.md

Testing Evidence

None at this time.

As part of this Pull Request I have

…erated docs file (1) to parameterize route entry name(s) in the route table (VWAN hub to Az Firewall).
@oZakari
Copy link
Contributor

oZakari commented Apr 30, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari
Copy link
Contributor

oZakari commented Apr 30, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari merged commit 59a7e08 into Azure:main Apr 30, 2024
10 checks passed
@alisakina99 alisakina99 deleted the ParameterizeRouteTable branch April 30, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the route name to all_traffic
2 participants