Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vwanConnectivity] Refactor to support multi-region hubs #805

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

sebassem
Copy link
Contributor

@sebassem sebassem commented Jul 4, 2024

Overview/Summary

This PR is changing the way Azure Firewall parameters are handled in the module to be per Hub, currently there are common parameters for Azure Firewall that will be applied to every instance in all hubs. Customers may want to customize the policies, dns servers,.tiers,...etc per region per hub.

This PR fixes/adds/changes/removes

  1. Closes Regional Azure Firewall Policies #750

Breaking Changes

  1. Moved the following parameters into the UDT of virtualWanOptionsType to allow for different firewall configuration per hub/region
  • parAzFirewallDnsServers
  • parAzFirewallIntelMode
  • parAzFirewallDnsProxyEnabled
  • parAzFirewallTier
  • parAzFirewallAvailabilityZones

Testing Evidence

image

As part of this Pull Request I have

@sebassem sebassem self-assigned this Jul 4, 2024
@sebassem sebassem marked this pull request as ready for review July 4, 2024 15:15
@oZakari
Copy link
Contributor

oZakari commented Jul 9, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari added Area: Networking 🌐 Issues / PR's related to Networking Type: Bug 🪲 Something isn't working labels Jul 11, 2024
@oZakari
Copy link
Contributor

oZakari commented Jul 12, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari merged commit b702fbe into Azure:main Jul 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Networking 🌐 Issues / PR's related to Networking Type: Bug 🪲 Something isn't working
Projects
None yet
2 participants