Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Multi region support for accelerator #857

Merged
merged 18 commits into from
Sep 27, 2024
Merged

Conversation

sebassem
Copy link
Contributor

@sebassem sebassem commented Sep 17, 2024

Overview/Summary

Creates necessary changes to ALZ-PowerShell-Config for Accelerator v2 to support multi-region deployments. Also, includes relevant parameter file for VWAN and hubnetworking module that supports deployments to 2 regions.

Finally, adds notice for the upcoming change to zone redundant configurations by default.

Related Issues/Work Items

Closes #675
Fixes AB#34223

This PR fixes/adds/changes/removes

  • Added an additional hubNetworking module for 2-region deployments
  • Added an additional parameters file in case multi-region is selected, to deploy both regions
  • Updated some parameters' values to include the region to make a clear distinction between them like bastion and nsgs
  • Implement vnet peering between the 2 hubs
  • Add notice for zone redundant configuration date in Q4 2024.

Breaking Changes

None

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, clearly work in progress, so feel free to ignore my comments as you likely have them on your todo list anyway.

accelerator/.config/ALZ-Powershell-Auto.config.json Outdated Show resolved Hide resolved
@oZakari oZakari changed the title Multi region initial PR feat: Multi region initial PR Sep 17, 2024
@oZakari oZakari changed the title feat: Multi region initial PR feat: Multi region support for accelerator Sep 26, 2024
@oZakari oZakari closed this Sep 27, 2024
@oZakari oZakari reopened this Sep 27, 2024
@oZakari
Copy link
Contributor

oZakari commented Sep 27, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari added the Area: Networking 🌐 Issues / PR's related to Networking label Sep 27, 2024
@oZakari oZakari marked this pull request as ready for review September 27, 2024 04:29
@oZakari oZakari merged commit 2b7ee23 into Azure:main Sep 27, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Networking 🌐 Issues / PR's related to Networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature-Request: Multi-Region -> Hub-and-spoke topology
3 participants