Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: General networking fixes and add active-active capability for vnet gateway #863

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Sep 24, 2024

Overview/Summary

This pull request includes several updates to the infra-as-code/bicep/modules/hubNetworking/hubNetworking.bicep file to upgrade the API versions of various Azure resources and add support for active-active configurations for gateways.

API Version Upgrades:

  • Updated API versions for resBastionSubnetRef, resBastionNsg, resBastion, resGatewaySubnetRef, resAzureFirewallSubnetRef, resAzureFirewallMgmtSubnetRef, resFirewallPolicies, resAzureFirewall, and resHubRouteTable to 2024-01-01. [1] [2] [3] [4] [5] [6] [7]

Gateway Configuration Enhancements:

  • Added support for active-active gateway configurations by creating a second public IP if the gateway is active-active.
  • Modified ipConfigurations to include a secondary IP configuration when activeActive is true.

Conditional Outputs:

  • Updated the outDdosPlanResourceId output to conditionally return an empty string if DDoS protection is not enabled.

Related Issues/Work Items

Fixes #561
Fixes AB#35815

This PR fixes/adds/changes/removes

  1. Adds the capability to support active-active virtual network gateway configuration
  2. Fixes issues with parDDosId when parDDosEnabled is set to false.
  3. Updates hub networking module api versions

Breaking Changes

None

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

@oZakari oZakari added Area: Networking 🌐 Issues / PR's related to Networking Type: Bug 🪲 Something isn't working labels Sep 24, 2024
@oZakari oZakari changed the title fix: Add active-active capability for vnet gateway fix: General networking fixes and add active-active capability for vnet gateway Sep 24, 2024
@oZakari
Copy link
Contributor Author

oZakari commented Sep 24, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@sebassem sebassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari merged commit 2642d62 into Azure:main Sep 24, 2024
36 checks passed
@oZakari oZakari deleted the general-networking-bugs branch September 24, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Networking 🌐 Issues / PR's related to Networking Type: Bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲 Bug Report - Support for active/active VNET Gateway
2 participants