Log successful cluster deletions #3934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ventifus
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
In the e2e logs for deletion, it does not appear to delete via backend operation, so it's not testing this change. |
edisonLcardenas
approved these changes
Nov 5, 2024
bitoku
approved these changes
Nov 7, 2024
|
Please rebase pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-11772
What this PR does / why we need it:
Currently we don't log the completion of successful cluster deletions. That's because the logs (and other metrics) get emitted by endLease(), and the lease doesn't get released for deletions because the cluster doc gets deleted instead.
Moves the logging and metrics functions to a emitTerminalMetrics() function that can be called directly at the end of the deletion operation.
Test plan for issue:
E2E will exercise this as part of cluster creation and deletion. Check that the appropriate "long running operation succeeded" log is emitted for cluster creation. Check that "long running operation succeeded" now gets logged on deletion.
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?