Fix unexpected workload identity update in workload identity clusters #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajdeepc2792
added
bug
tsatam
reviewed
Nov 22, 2024
pkg/util/platformworkloadidentity/platformworkloadidentityrolesbyversion.go
Show resolved
Hide resolved
rajdeepc2792
force-pushed
the
rajdeepc2792/ARO-12514
branch
2 times, most recently
from
6ebcba3 to
00903b2
Compare
rajdeepc2792
force-pushed
the
rajdeepc2792/ARO-12514
branch
from
00903b2 to
88b34b0
Compare
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
…reate/update flows
…dentityRoleSets
rajdeepc2792
force-pushed
the
rajdeepc2792/ARO-12514
branch
from
88b34b0 to
3d66fea
Compare
rajdeepc2792
requested review from
jewzaam,
bennerv,
hawkowl and
rogbas
as code owners
rajdeepc2792
requested review from
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27,
bitoku and
fahlmant
as code owners
Comment on lines
+153
to
+163
| if oc.UsesWorkloadIdentity() { | ||
| if err := f.validatePlatformWorkloadIdentities(oc); err != nil { | ||
| return api.ValidationResult{ | ||
| Status: api.ValidationStatusFailed, | ||
| Error: &api.CloudErrorBody{ | ||
| Code: api.CloudErrorCodeInvalidParameter, | ||
| Message: err.Error(), | ||
| }, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Just a nice to have, since we only expect one return here, is it not possible to simplify to just one "if" condition or create a guard clause instead of nesting another "if" condition?
e.g. if oc.UsesWorkloadIdentity() && f.validatePlatformWorkloadIdentities(oc) != nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-12514
What this PR does / why we need it:
Test plan for issue:
[x] Unit tests added/updated for the above implementation
[x] Create/Update MIWI cluster in local
[x] CI
[x] e2e
Is there any documentation that needs to be updated for this PR?
Not yet.
How do you know this will function as expected in production?
Feature is not in production yet.