MIMO AKS Additions #3988
Draft
MIMO AKS Additions #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a few things that aren't completed in this template yet, in all likelihood most, if not all of what's in the secret_provider will need to be moved to just plain environment variables supplied with a config map as most of these don't seem like they would have any secrets in them (likely that the rp pulls them in itself?). It's not clear what settings are needed fo rthe service account just yet, and deploying with pipeline variables isn't entirely clear yet either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few things that aren't completed in this template yet, in all likelihood most, if not all of what's in the secret_provider will need to be moved to just plain environment variables supplied with a config map as most of these don't seem like they would have any secrets in them (likely that the rp pulls them in itself?).
It's not clear what settings are needed fo rthe service account just yet, and deploying with pipeline variables isn't entirely clear yet either.