Remove unused ClusterManager API structs #4011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
added
priority-high
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
hawkowl
requested review from
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
thanks! We're partially duplicating this change in https://github.com/Azure/ARO-RP/pull/4014/files for the purposes of getting it reviewed by ARM (and probably breaking changes team too), so I'll put a hold here. The only question I have is why we're removing the resource types from all API versions instead of just subsequent ones. I am not sure that the ARM team would be OK with such a change. |
|
@cadenmarchese Since they were never wired up and we're implementing things differently, plus they don't conform with the ARM guidelines, it's easier to remove them. We could perhaps just not upload previous APIs if it's too much of an issue, but we don't want to keep all of the generation code around just for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-9171
What this PR does / why we need it:
Removes the invalid ClusterManager API structs + generation code + regenerates the clients.
Test plan for issue:
Unit test/E2E.
Is there any documentation that needs to be updated for this PR?
N/A?
How do you know this will function as expected in production?
Should need to pass ARM review.