Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize with basic features #1

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Initialize with basic features #1

merged 2 commits into from
Sep 11, 2023

Conversation

Eskibear
Copy link
Member

@Eskibear Eskibear commented Sep 7, 2023

  • load APIs supporting connection string and AAD
  • key/label filters
  • trim key prefixes

@Eskibear
Initialize with basic features
661f8e2 
- load APIs supporting connection string and AAD
- key/label filters
- trim key prefixes
@Eskibear Eskibear requested a review from avanigupta September 7, 2023 10:48
@Eskibear Eskibear mentioned this pull request Sep 11, 2023
Merged
@Eskibear
Copy link
Member Author

@avanigupta
Previous comments all addressed. Let me know if there's any suggestion further, or I will proceed to merge this init PR to unblock coming features.Thanks.

avanigupta
avanigupta reviewed Sep 11, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/AzureAppConfigurationImpl.ts Show resolved Hide resolved
src/AzureAppConfigurationImpl.ts Outdated Show resolved Hide resolved
src/Load.ts Outdated Show resolved Hide resolved
@Eskibear Eskibear merged commit 05190f8 into main Sep 11, 2023
@Eskibear Eskibear deleted the yanzh/init branch September 11, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avanigupta avanigupta avanigupta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eskibear @avanigupta