Add deprecation notice to GitHub Action #55
Conversation
README.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| # Deprecation Notice | |||
|
|
|||
| This Action is deprecated. Instead, you can set up ongoing configuration file import using [Azure CLI](https://learn.microsoft.com/en-us/azure/azure-app-configuration/push-kv-github-action) GitHub action, which offers full capabilities for file importing to your App Configuration store. | |||
There was a problem hiding this comment.
Change the wording a little bit.
This GitHub action has been deprecated. The Azure CLI for Azure App Configuration provides full capabilities for importing configuration files into Azure App Configuration. Follow these instructions to set it up in your GitHub actions.
There was a problem hiding this comment.
This has been updated
src/main.ts
Outdated
| @@ -14,6 +14,7 @@ async function main(): Promise<void> { | |||
| } catch (error) { | |||
| core.setFailed(getErrorMessage(error)); | |||
| } | |||
| core.warning("THIS ACTION IS DEPRECATED. Use azure/cli@v2 to replace this action. Find it here: https://github.com/Azure/cli"); | |||
There was a problem hiding this comment.
I'm wondering if we should move this to the beginning instead of at the end.
I think we should point users to our document instead of the CLI action.
THIS ACTION IS DEPRECATED. Follow this guide to import your configuration into Azure App Configuration using GitHub Actions: https://aka.ms/appconfig/githubactions
There was a problem hiding this comment.
On the placing of the warning, I don't really have a strong opinion on it, I saw github add their warnings at the end for example, node 16 warning appeared at the end.
I have updated the string.
Added warning that action is deprecated.