Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Core.IncludeResourcesInResourceGroup setting not working as expected #619

Closed
matthewponzio opened this issue May 9, 2022 · 3 comments

Comments

@matthewponzio
Copy link

matthewponzio commented May 9, 2022

Describe the bug
I have the following configuration in my settings.json

"Core.IncludeResourcesInResourceGroup": ["cloud-eng-network"],

I would expect that the Pull pipeline would then ONLY discover Resources in Resource Groups named cloud-eng-network

However, when I add Resources to Resource Groups OTHER THAN cloud-eng-network, they are still being discovered.

Steps to reproduce

  1. Create a Resource Group named cloud-eng-network
  2. Create a Resource Group named <your_choice>
  3. Configure "Core.IncludeResourcesInResourceGroup": ["cloud-eng-network"], in settings.json
  4. Add any Resource to each of the two Resource Groups
  5. Run the Pull pipeline
  6. Notice that BOTH Resources are discovered -- instead of ONLY the Resource within the cloud-eng-network Resource Group

Screenshots
image

Screen Shot 2022-05-09 at 3 12 23 PM

Screen Shot 2022-05-09 at 3 13 22 PM

Screen Shot 2022-05-09 at 3 15 13 PM

@matthewponzio matthewponzio changed the title Bug Report Bug Report: Core.IncludeResourcesInResourceGroup setting not working as expected May 9, 2022
@daltondhcp
Copy link
Contributor

Thank you for raising this. Maybe I wasn’t very clear around this in the question you asked under discussions. That feature is introduced in #609, but we haven’t cut a release for it yet. Targeting for 1.8.0 in a week or so.

Apologies for the inconvenience.

@daltondhcp daltondhcp closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2022
@matthewponzio
Copy link
Author

@daltondhcp Oh my...of course..derp. I spent a bunch of time reading through the code to see if maybe I was misunderstanding the intent of the feature..and I'm like yeah, it looks like it's all set up to work like I understood?! But then...I'm looking at my cloned copy of master ...and not 1.7.7. Ugh. 🙄 I didn't actually think it was a bug, but it seemed more appropriate to bring it up there than in Discussions. Anyway, thanks again for the reply. You definitely saved me some additional head scratching today!

@daltondhcp
Copy link
Contributor

Any time, looking forward to your feedback when we have shipped it! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants