Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional controls for resource discovery #609

Merged
merged 7 commits into from
May 5, 2022

Conversation

Jefajers
Copy link
Member

@Jefajers Jefajers commented May 2, 2022

Overview/Summary

This PR adds two new controls to support additional control of resource discovery.
IncludeResourcesInResourceGroup
IncludeResourceType
Closes #608

This PR fixes/adds/changes/removes

  1. Adds logic to determine which resource groups to include during resource discovery (Pull) at resource group scope
  2. Adds logic to determine which resource providers and types to include during resource discovery (Pull) at resource group scope
  3. Changes Wiki to include new settings and add example scenarios to FAQ section
  4. Default values for both new settings are set to wildcard * to ensure compatibility with setting files not containing these controls.

Breaking Changes

  1. N/A

Testing Evidence

Tests have been performed with both settings separately and combined with each other in combination with existing resource and child resource discovery.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers added the enhancement New feature or request label May 2, 2022
@Jefajers Jefajers added this to the Release - v1.8.0 milestone May 2, 2022
@Jefajers Jefajers requested a review from a team as a code owner May 2, 2022 16:38
@Jefajers Jefajers changed the title ExpandResourceDiscoverySettings Adding additional controls of resource discovery May 2, 2022
@Jefajers Jefajers changed the title Adding additional controls of resource discovery Adding additional controls for resource discovery May 2, 2022
daltondhcp
daltondhcp previously approved these changes May 2, 2022
src/internal/functions/Get-AzOpsResourceDefinition.ps1 Outdated Show resolved Hide resolved
src/internal/functions/Get-AzOpsResourceDefinition.ps1 Outdated Show resolved Hide resolved
src/localized/en-us/Strings.psd1 Outdated Show resolved Hide resolved
Co-authored-by: Johan Dahlbom <johan@dahlbom.eu>
Co-authored-by: Johan Dahlbom <johan@dahlbom.eu>
Co-authored-by: Johan Dahlbom <johan@dahlbom.eu>
@Jefajers Jefajers temporarily deployed to test May 2, 2022 18:24 Inactive
@Jefajers Jefajers temporarily deployed to test May 4, 2022 08:57 Inactive
Copy link
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@Jefajers Jefajers deleted the ExpandResourceDiscovery branch May 24, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add settings for more flexible control of resource discovery
2 participants