Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added powershell version to Metadata of Template #419

Merged

Conversation

SomilGanguly
Copy link
Contributor

Overview/Summary

This Pull Request is for merging the Metadata Enhancements to AzOps.

This PR fixes/adds/changes/removes

  1. Adds - Metadata to the AzOps pull templates

Breaking Changes

  1. N/A

Testing Evidence

This feature has been tested and verified.

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located in the Enterprise-Scale repo in the directory: /docs/wiki/whats-new.md)

@SomilGanguly SomilGanguly requested a review from ljtill September 2, 2021 09:58
@SomilGanguly SomilGanguly requested a review from a team as a code owner September 2, 2021 09:58
@uday31in uday31in requested a review from daltondhcp September 2, 2021 10:00
@uday31in
Copy link
Member

uday31in commented Sep 2, 2021

I very much like the idea however i worry about churn it will generate when PowerShell module is updated. Thoughts?

@daltondhcp
Copy link
Contributor

daltondhcp commented Sep 2, 2021

Agree with @uday31in (as was also mentioned in #363 related to this feature request) - to reduce potential template churn I'd prefer to include only name and not version in the metadata.

@daltondhcp daltondhcp added area/powershell do-not-merge Not ready to merge enhancement New feature or request waiting-for-response Maintainers have replied and are awaiting a response from the bug/issue/feature creator labels Sep 2, 2021
@SomilGanguly
Copy link
Contributor Author

SomilGanguly commented Sep 2, 2021

I very much like the idea however i worry about churn it will generate when PowerShell module is updated. Thoughts?

@uday31in - Agreed Uday, So as per Johan's comment have removed the version and updated the metadata name to _generator

@ljtill ljtill linked an issue Sep 2, 2021 that may be closed by this pull request
@daltondhcp
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@daltondhcp daltondhcp removed do-not-merge Not ready to merge waiting-for-response Maintainers have replied and are awaiting a response from the bug/issue/feature creator labels Sep 3, 2021
Copy link
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SomilGanguly SomilGanguly merged commit 3c8999b into Azure:main Sep 3, 2021
@SomilGanguly SomilGanguly deleted the sogangul-AzOps-MetadataEnhancement branch September 9, 2021 10:50
@ljtill ljtill removed enhancement New feature or request area/powershell labels Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add generator metadata for generated templates
4 participants