Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invalid characters logic #700

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

Jefajers
Copy link
Member

@Jefajers Jefajers commented Nov 8, 2022

Overview/Summary

This PR closes #691 by adding a function to remove invalid characters at filename creation.

The purpose is to ensure that even a resource in Azure with a name containing characters not valid as filenames are handled appropriately and harmonized without effecting other aspects.

This PR fixes/adds/changes/removes

  1. Adds Remove-AzOpsInvalidCharacters.ps1
  2. Changes AzOpsScope.ps1

Breaking Changes

  1. N/A

Testing Evidence

Testing for ChildResource included in PR. In addition to that tests have been performed at Management group, Subscription, Resource group and Resource scope.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers added the enhancement New feature or request label Nov 8, 2022
@Jefajers Jefajers added this to the Release - v1.9.1 milestone Nov 8, 2022
@Jefajers Jefajers requested review from a team as code owners November 8, 2022 17:00
@Jefajers Jefajers temporarily deployed to test November 8, 2022 17:00 Inactive
Copy link
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎆

@Jefajers Jefajers merged commit adbe044 into Azure:main Nov 9, 2022
@Jefajers Jefajers deleted the illegalFilesystemCharacters0 branch November 9, 2022 10:40
@daltondhcp daltondhcp mentioned this pull request Feb 24, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid illegal filesystem characters
2 participants