Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft.authorization/locks support #704

Merged
merged 8 commits into from
Nov 16, 2022

Conversation

Jefajers
Copy link
Member

Overview/Summary

This PR closes #662 by adding pull, push and deletion support for Microsoft.authorization/locks at Subscription and Resource Group scope.

This PR fixes/adds/changes/removes

  1. Adds Get-AzOpsResourceLock.ps1
  2. Changes Remove-AzOpsDeployment.ps1
  3. Changes ResourceDeletion.md
  4. Changes Settings.md
  5. Changes Remove-AzOpsTestsDeployment.ps1
  6. Changes Invoke-AzOpsPull.ps1
  7. Changes Invoke-AzOpsPush.ps1
  8. Changes Core.ps1
  9. Changes Get-AzOpsResourceDefinition.ps1
  10. Changes Get-AzOpsRoleDefinition.ps1
  11. Changes Strings.psd1
  12. Changes Repository.Tests.ps1
  13. Changes azuredeploy.jsonc

Breaking Changes

  1. N/A

Testing Evidence

Automated testing for lock pull, push and deletion with dependency evaluation is included in PR.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers added the enhancement New feature or request label Nov 15, 2022
@Jefajers Jefajers added this to the Release - v1.9.1 milestone Nov 15, 2022
@Jefajers Jefajers requested a review from a team as a code owner November 15, 2022 11:17
@Jefajers Jefajers requested a review from a team as a code owner November 15, 2022 11:17
@Jefajers Jefajers temporarily deployed to test November 15, 2022 19:58 Inactive
Copy link
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Jefajers Jefajers merged commit f19e098 into Azure:main Nov 16, 2022
@Jefajers Jefajers deleted the Microsoft.Authorization/locks branch November 16, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource Group Lock (Microsoft.Authorization/locks) resources cannot be Pull'd
2 participants