-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Support for Filtering Specific Subscription Id's to Include in ChildResource Discovery #880
Merged
Jefajers
merged 5 commits into
Azure:main
from
Jefajers:subscriptionsToIncludeChildResources
May 2, 2024
Merged
Adding Support for Filtering Specific Subscription Id's to Include in ChildResource Discovery #880
Jefajers
merged 5 commits into
Azure:main
from
Jefajers:subscriptionsToIncludeChildResources
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jsandquist, what do you think about this addition based on our previous dialog? |
Great work - I'll test it out in my environment. |
jsandquist
reviewed
Apr 25, 2024
Big thumbs up for this feature - works as expected when tested in my environment. Thank you! :-) |
daltondhcp
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This PR adds a new setting called
Core.SubscriptionsToIncludeChildResource
with a default value or["*"]
.If you have a need to specify which subscription id's AzOps limits child resource discovery to, specify the desired subscription id or id's
["66d96157-55b3-47f3-b9a1-171778f99f0e","8b03299b-5880-4b2e-b026-e24484110151"]
.This PR fixes/adds/changes/removes
Frequently-Asked-Questions.md
Settings.md
Core.ps1
Get-AzOpsResourceDefinition.ps1
Repository.Tests.ps1
azuredeploy.jsonc
Functional.Tests.ps1
Breaking Changes
N/A
Testing Evidence
This logic has been manually tested in addition to this PR also contains an added automated testing step to ensure that the subscription Id filter behaves as intended.
As part of this Pull Request I have
main
branch