Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for Filtering Specific Subscription Id's to Include in ChildResource Discovery #880

Merged
merged 5 commits into from
May 2, 2024

Conversation

Jefajers
Copy link
Member

@Jefajers Jefajers commented Apr 24, 2024

Overview/Summary

This PR adds a new setting called Core.SubscriptionsToIncludeChildResource with a default value or ["*"].

If you have a need to specify which subscription id's AzOps limits child resource discovery to, specify the desired subscription id or id's ["66d96157-55b3-47f3-b9a1-171778f99f0e","8b03299b-5880-4b2e-b026-e24484110151"] .

This PR fixes/adds/changes/removes

  1. Changes Frequently-Asked-Questions.md
  2. Changes Settings.md
  3. Changes Core.ps1
  4. Changes Get-AzOpsResourceDefinition.ps1
  5. Changes Repository.Tests.ps1
  6. Changes azuredeploy.jsonc
  7. Changes Functional.Tests.ps1

Breaking Changes

N/A

Testing Evidence

This logic has been manually tested in addition to this PR also contains an added automated testing step to ensure that the subscription Id filter behaves as intended.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers added the enhancement New feature or request label Apr 24, 2024
@Jefajers Jefajers added this to the v2.6.3 milestone Apr 24, 2024
@Jefajers Jefajers requested review from a team as code owners April 24, 2024 13:26
@Jefajers Jefajers closed this Apr 24, 2024
@Jefajers Jefajers reopened this Apr 24, 2024
@Jefajers
Copy link
Member Author

@jsandquist, what do you think about this addition based on our previous dialog?

@jsandquist
Copy link
Contributor

Great work - I'll test it out in my environment.

@jsandquist
Copy link
Contributor

Big thumbs up for this feature - works as expected when tested in my environment. Thank you! :-)

@Jefajers Jefajers added the wiki-doc Improvements or additions to documentation label Apr 30, 2024
@Jefajers Jefajers merged commit 613fceb into Azure:main May 2, 2024
4 checks passed
@Jefajers Jefajers deleted the subscriptionsToIncludeChildResources branch May 2, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wiki-doc Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants