Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added retry capability for pulling PIM resources #900

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Added retry capability for pulling PIM resources #900

merged 3 commits into from
Dec 12, 2024

Conversation

borondy
Copy link
Contributor

@borondy borondy commented Oct 16, 2024 •
edited by Jefajers
Loading

Overview/Summary

This PR adds retry logic in the Get-AzOpsRoleEligibilityScheduleRequest function for Get-AzRoleEligibilitySchedule and Get-AzRoleEligibilityScheduleRequest using Invoke-AzOpsScriptBlock to manage retry and backoff logic.

This PR fixes/adds/changes/removes

  1. Getting PIM resources should have retry capability #899

Breaking Changes

N/A

Testing Evidence

Executed in our own environment.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@borondy borondy requested review from a team as code owners October 16, 2024 11:37
@borondy borondy changed the title Added retry capability Added retry capability for pulling PIM resources Oct 16, 2024
@daltondhcp daltondhcp requested a review from Jefajers October 18, 2024 05:32
@Jefajers Jefajers added enhancement New feature or request area/powershell labels Dec 12, 2024
@Jefajers Jefajers added this to the v2.6.6 milestone Dec 12, 2024
@Jefajers Jefajers linked an issue Dec 12, 2024 that may be closed by this pull request
Getting PIM resources should have retry capability #899
Closed
@Jefajers Jefajers self-assigned this Dec 12, 2024
@Jefajers Jefajers merged commit 5035c74 into Azure:main Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefajers Jefajers Jefajers approved these changes

Assignees

@Jefajers Jefajers

Labels
area/powershell enhancement New feature or request
Projects
AzOps
Status: Pending release
Milestone
v2.6.6
Development

Successfully merging this pull request may close these issues.

Getting PIM resources should have retry capability
2 participants
@borondy @Jefajers