-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added additional constructor for AzOpsRoleEligibilityScheduleRequest #902
Merged
Jefajers
merged 6 commits into
Azure:main
from
borondy:feature/role-eligibility-schedule-request-constructor-wo-schedule-request
Dec 11, 2024
Merged
Added additional constructor for AzOpsRoleEligibilityScheduleRequest #902
Jefajers
merged 6 commits into
Azure:main
from
borondy:feature/role-eligibility-schedule-request-constructor-wo-schedule-request
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Added additional constructor for AzOpsRoleEligibilityScheduleRequest to be able to create RoleEligibilityScheduleRequest template based on the RoleEligibilitySchedule resource without an existing RoleEligibilityScheduleRequest resource.
See reasons in #901.
This PR also contains bumping version dependencies:
PSFramework 1.12.346
Az.Accounts 4.0.0
Az.Billing 2.1.0
Az.ResourceGraph 1.0.1
Az.Resources 7.6.0
NOTE
To achieve this the RequestType
'AdminAssign'
value is hardcoded by the classAzOpsRoleEligibilityScheduleRequest.ps1
. Ideally we get theRequestType
from RoleEligibilityScheduleRequest, if that information is not available the class falls back to'AdminAssign'
.This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
We were able to successfully create RoleEligibilityScheduleRequest templates during our pipeline runs where the actual Request was not found in azure:
As part of this Pull Request I have
main
branch