Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional constructor for AzOpsRoleEligibilityScheduleRequest #902

Conversation

borondy
Copy link
Contributor

@borondy borondy commented Oct 16, 2024

Overview/Summary

Added additional constructor for AzOpsRoleEligibilityScheduleRequest to be able to create RoleEligibilityScheduleRequest template based on the RoleEligibilitySchedule resource without an existing RoleEligibilityScheduleRequest resource.
See reasons in #901.

This PR also contains bumping version dependencies:

  • PSFramework 1.12.346
  • Az.Accounts 4.0.0
  • Az.Billing 2.1.0
  • Az.ResourceGraph 1.0.1
  • Az.Resources 7.6.0

NOTE
To achieve this the RequestType 'AdminAssign' value is hardcoded by the class AzOpsRoleEligibilityScheduleRequest.ps1. Ideally we get the RequestType from RoleEligibilityScheduleRequest, if that information is not available the class falls back to 'AdminAssign'.

This PR fixes/adds/changes/removes

  1. PIM RoleEligibilitySchedule is ignored if RoleEligibilityScheduleRequest is missing. #901

Breaking Changes

  1. N/A

Testing Evidence

We were able to successfully create RoleEligibilityScheduleRequest templates during our pipeline runs where the actual Request was not found in azure:
image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers
Copy link
Member

Hi @borondy, I would like to contribute to your PR, would you mind allowing me permissions to push to borondy/AzOps

@Jefajers Jefajers added this to the v2.6.6 milestone Nov 29, 2024
@Jefajers Jefajers added the bug Something isn't working label Nov 29, 2024
@Jefajers Jefajers self-assigned this Nov 29, 2024
@Jefajers Jefajers merged commit c47f29e into Azure:main Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies
Projects
Status: Pending release
Development

Successfully merging this pull request may close these issues.

PIM RoleEligibilitySchedule is ignored if RoleEligibilityScheduleRequest is missing.
2 participants