Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to DataConnectors/AWS-SecurityHubFindings #11211

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

karpikpl
Copy link

@karpikpl karpikpl commented Oct 2, 2024

Required items, please complete

Change(s):

  • Updated Exception type in python code that was no longer resolving
  • Updated Azure Function extensions to latest - v4
  • Updated Readme file with information on managed identity (since getting tokens by managed identities for themselves is no longer supported in most tenants)
  • Code was reformatted with black formatter

Reason for Change(s):

  • Customer reported errors when running the code

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • Tested function with AWS

Checked that the validations are passing and have addressed any issues that are present:

  • No validations changed

@karpikpl karpikpl requested review from a team as code owners October 2, 2024 20:22
@v-atulyadav v-atulyadav added Connector Connector specialty review needed Solution Solution specialty review needed labels Oct 3, 2024
@v-prasadboke
Copy link
Contributor

Hello @karpikpl, Please try to resolve Code QL failures

@karpikpl
Copy link
Author

I've updated the code and tested with AWS:
image

had some issues with AWS permissions - hence 30 failed runs :( but eventually it worked

@karpikpl
Copy link
Author

@v-prasadboke - how can I address those 2 failing checks for Sentinel Content Validation ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants